-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix post-merge tests #1752
Fix post-merge tests #1752
Conversation
57a32e7
to
a395f8d
Compare
@@ -50,7 +50,7 @@ jobs: | |||
- name: Build Cantera | |||
run: python3 `which scons` build env_vars=all | |||
CXX=clang++-14 CC=clang-14 f90_interface=n extra_lib_dirs=/usr/lib/llvm/lib | |||
-j4 debug=n --debug=time logging=debug | |||
-j4 debug=n --debug=time logging=debug python_package=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been wondering if we should update the default to build the Python package unless it is explicitly disabled, so that missing a Python dependency results in a build failure unless you set python_package=n
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm for it! Do you want to make an enhancements issue so we can at least try to document some tradeoffs?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1752 +/- ##
==========================================
- Coverage 73.13% 73.12% -0.01%
==========================================
Files 381 381
Lines 54134 54134
Branches 9222 9224 +2
==========================================
- Hits 39590 39587 -3
- Misses 11587 11589 +2
- Partials 2957 2958 +1 ☔ View full report in Codecov by Sentry. |
fb79b2e
to
ec109f9
Compare
b7004de
to
9d9580e
Compare
9d9580e
to
8736cbc
Compare
We've already warned the user that their Python may be unsupported, so try the wheel build with pip anyways.
Set up unit tests to be skipped if pint can't be imported. There is a known bug with pint and Python 3.13 that prevents importorskip from working.
8736cbc
to
d039b1f
Compare
As of yesterday, Pandas pre-release wheels were available for Python 3.13: https://github.com/Cantera/cantera/actions/runs/10207129578/job/28266033217 They are no longer available right now 😞 |
I also don't think I did anything that would start causing the sample tests to fail. It does look like the artifact uploaded of |
It's uploading the symlink, not the actual file the symlink points to. Seems to be an unexpected change introduced in the latest version of |
That was my guess, that it was uploading the symlink. Glad to know it's not just us. I'll pin to 4.3.4 for now. |
Based on pandas-dev/pandas#59372, it looks like wheels get removed after some time in the nightly index, probably to avoid overloading Anaconda's willingness to provide storage 😬 And as it happens, Pandas wheels haven't been uploading for a while, due to test failures on their part. So I'm fine with accepting those jobs failing. |
f825b51
to
6b2c8bb
Compare
Version 4.3.5 broke uploading symlinks as artifacts. Reverting to 4.3.4 should resolve this until the error is fixed.
6b2c8bb
to
57e1164
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bryanwweber. This all looks fine to me.
Changes proposed in this pull request
SpecifierSet
s for version comparisons to allow pre-release versions of packages. This shouldn't change any behavior for stable versions.hdf
variables no longer need to be specified to SCons CLI, they're handled by SConstruct since Configure libhdf5_serial if it's available #1723If applicable, fill in the issue number this pull request is fixing
Closes #1751
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverage