-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): simplify the CI and image building #1015
Open
goldmedal
wants to merge
3
commits into
Canner:main
Choose a base branch
from
goldmedal:chore/reduce-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,129 @@ | ||
name: Rust | ||
|
||
on: | ||
pull_request: | ||
paths: | ||
- 'wren-core-base/**' | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.event.number }} | ||
cancel-in-progress: true | ||
|
||
defaults: | ||
run: | ||
working-directory: wren-core-base | ||
|
||
jobs: | ||
# Check crate compiles | ||
linux-build-lib: | ||
name: cargo check | ||
runs-on: ubuntu-latest | ||
container: | ||
image: amd64/rust | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Setup Rust toolchain | ||
uses: ./.github/actions/rust/setup-builder | ||
with: | ||
rust-version: stable | ||
|
||
- name: Cache Cargo | ||
uses: actions/cache@v4 | ||
with: | ||
path: | | ||
~/.cargo/bin/ | ||
~/.cargo/registry/index/ | ||
~/.cargo/registry/cache/ | ||
~/.cargo/git/db/ | ||
./wren-core/target/ | ||
# this key equals the ones on `linux-build-lib` for re-use | ||
key: cargo-cache-benchmark-${{ hashFiles('wren-core/Cargo.toml') }} | ||
|
||
- name: Check datafusion-common without default features | ||
run: cargo check --all-targets | ||
goldmedal marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# Run tests | ||
linux-test: | ||
name: cargo test (amd64) | ||
needs: [ linux-build-lib ] | ||
runs-on: ubuntu-latest | ||
container: | ||
image: amd64/rust | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
submodules: true | ||
- name: Setup Rust toolchain | ||
uses: ./.github/actions/rust/setup-builder | ||
with: | ||
rust-version: stable | ||
- name: Run tests (excluding doctests) | ||
run: cargo test --lib --tests --bins | ||
- name: Verify Working Directory Clean | ||
run: git diff --exit-code | ||
|
||
macos-aarch64: | ||
name: cargo test (macos-aarch64) | ||
runs-on: macos-14 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
submodules: true | ||
- name: Setup Rust toolchain | ||
uses: ./.github/actions/rust/setup-macos-aarch64-builder | ||
- name: Run tests (excluding doctests) | ||
shell: bash | ||
run: cargo test --lib --tests --bins | ||
|
||
check-fmt: | ||
name: Check cargo fmt | ||
runs-on: ubuntu-latest | ||
container: | ||
image: amd64/rust | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Setup Rust toolchain | ||
uses: ./.github/actions/rust/setup-builder | ||
with: | ||
rust-version: stable | ||
- name: Run | ||
run: cargo fmt --all -- --check | ||
|
||
clippy: | ||
name: clippy | ||
needs: [ linux-build-lib ] | ||
runs-on: ubuntu-latest | ||
container: | ||
image: amd64/rust | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
submodules: true | ||
- name: Setup Rust toolchain | ||
uses: ./.github/actions/rust/setup-builder | ||
with: | ||
rust-version: stable | ||
- name: Install Clippy | ||
run: rustup component add clippy | ||
- name: Run clippy | ||
run: cargo clippy --all-targets --all-features -- -D warnings | ||
|
||
cargo-toml-formatting-checks: | ||
name: check Cargo.toml formatting | ||
needs: [ linux-build-lib ] | ||
runs-on: ubuntu-latest | ||
container: | ||
image: amd64/rust | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
submodules: true | ||
- name: Setup Rust toolchain | ||
uses: ./.github/actions/rust/setup-builder | ||
with: | ||
rust-version: stable | ||
- name: Install taplo | ||
run: cargo +stable install taplo-cli --version ^0.9 --locked | ||
# if you encounter an error, try running 'taplo format' to fix the formatting automatically. | ||
- name: Check Cargo.toml formatting | ||
run: taplo format --check |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,4 +19,5 @@ wren-server/etc | |
__pycache__/ | ||
venv/ | ||
**/.env* | ||
**/.venv/ | ||
**/*.so |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix cache key to match working directory
The cache key references
wren-core
but the working directory is set towren-core-base
. This mismatch could lead to cache misses.📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in 9cc2356
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@goldmedal Thanks for addressing this in commit 9cc2356! Everything looks good now; no further changes needed.