-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wren-ai-service): add README about how to integrate dspy into wrenAI #892
Conversation
@@ -68,6 +68,58 @@ The evaluation results will be presented on Langfuse as follows: | |||
|
|||
![shallow_trace_example](../docs/imgs/shallow_trace_example.png) | |||
|
|||
|
|||
## How to use Dspy in Wren AI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be DSPy
## How to use Dspy in Wren AI | ||
### Step 1: Generate evaluation dataset | ||
|
||
Please use eval.py and the spider2 v1 dataset to train an optimized dspy module (https://github.com/taoyds/spider/tree/master/evaluation_examples/examples) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- what is
eval.py
? - should be Spider v1 dataset
- is there relevant command here?
Please use eval.py and the spider2 v1 dataset to train an optimized dspy module (https://github.com/taoyds/spider/tree/master/evaluation_examples/examples) | ||
The `prediction_eval_ask_9df57d69-250c-4a10-b6a5-6595509fed6b_2024_10_23_132136.toml` is a predict dataset generated without dspy | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make sure the given command is executable
@@ -175,16 +175,16 @@ async def _task(result: Dict[str, str]): | |||
valid_generation_results.append( | |||
{ | |||
"sql": quoted_sql, | |||
"correlation_id": addition.get("correlation_id", ""), | |||
"correlation_id": addition.get("correlation_id", "") if isinstance(addition, dict) else addition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious the reason of modification here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution, and I've left some comments here
because dspy code was removed from main. so move to eat/ai-service/dspy branch. close the PR see the follow-up #902 |
Related PRs
Added Readme and fixed a new exception.