CBuildCap: Raise an exception if reserved bits are set #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This raises a LengthViolation for now, but we may want to allocate a new exception code for reserved bits.
|
This is already solved by #36, which also solves the issue for other non-canonical capabilities |
|
Indeed, deriving from cs1 instead of setting the tag bit (which is what QEMU does) fixes that problem. Should probably change qemu to re-derive as well, that way we also get the canonicalization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This raises a LengthViolation for now, but we may want to allocate a new
exception code for reserved bits.