Invalid HTML generated due to post processing #8706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the CGAL specific postprocessing of the doxygen HTML files ("html_output_post_processing.py") invalid HTML is produced.
It is best shown by means of "Manual/how_to_cite.html":
```
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "https://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<link rel="canonical" href="https://doc.cgal.org/latest/Manual/how_to_cite.html"/>
<link rel="icon" type="image/png" href="../Manual/g-196x196-doc.png">
<meta http-equiv="Content-Type" content="text/xhtml;charset=UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=9">
<link href="cgal_stylesheet.css" rel="stylesheet" type="text/css">
<title>CGAL 6.1 - Manual: Acknowledging CGAL</title>
</head>
<head>
<link rel="canonical" href="https://doc.cgal.org/latest/Manual/how_to_cite.html"/>
</head>
<body>
....
```
We see here 2 problems
1. the `link` and `meta` statements are not properly closed (they shoudl end with `/>`)
2. there are 2 `head` sections in the file (this is "Manual/how_to_cite.html" specific).
Solution:
1. the `PyQuery` generates the problem regarding the missing `/` , which can be overcome by removing `method='html'`. At least on Windows the code `&CGAL#13;` appears (i.e. `^M`) this is filtered out
`2. code can be removed as it is already handled in the general part (just above)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the CGAL specific postprocessing of the doxygen HTML files ("html_output_post_processing.py") invalid HTML is produced. It is best shown by means of "Manual/how_to_cite.html":
We see here 2 problems
linkandmetastatements are not properly closed (they shoudl end with/>)headsections in the file (this is "Manual/how_to_cite.html" specific).Solution:
PyQuerygenerates the problem regarding the missing/, which can be overcome by removingmethod='html'. At least on Windows the code appears (i.e.^M) this is filtered out `