OSD capability #657
Open
OSD capability #657
+289
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reworks the previous mutter invoked OSD capability to be wayland friendly.
Now we specifically look for volume & brightness changes are display the OSD.
The volume changes are tracked in the same manner as the volume applet - i.e. GVC.
For brightness we grab the values straight out of the gsd component.
New here is OSD display when the caps-lock / num-lock keys are displayed. Very useful for small keyboards when you can easily press the caps-lock key accidentally. Note the comment in the keymap section of osdkeys where there appears to be a bug under wayland on first initialisation of the keymap - tests on X11 show the this code works just fine. i.e. if you press caps lock immediately on first login the OSD is not displayed. Quick test under Gtk4 and the equivalent standalone code for keymap initialisation works just fine. ho hum.
The old menus code has been nuked.
The daemon X11 stuff has also been removed - budgie-daemon is now running wayland not xwayland.
Submitter Checklist
git rebase -i(if needed)