Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows installer improvements #117

Merged
merged 12 commits into from
Dec 29, 2023
Merged

Windows installer improvements #117

merged 12 commits into from
Dec 29, 2023

Conversation

liias
Copy link
Contributor

@liias liias commented Dec 28, 2023 •
edited
Loading

Fix 4 issues from #116:

  • Problem 1: Missing ! in path
  • Problem 2: Install script continues after failed step
  • Problem 3: Missing uninstaller
  • Problem 4: Wrong path in Registry for system-wide install

@liias liias changed the title windows Windows installer improvements Dec 28, 2023
@liias liias self-assigned this Dec 28, 2023
@liias liias marked this pull request as ready for review December 29, 2023 02:42
@liias liias merged commit 1b36abf into main Dec 29, 2023
4 checks passed
@liias liias deleted the windows branch December 29, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liias liias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liias