Ensure backdrop cleanup is performed #4873
Conversation
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
| @@ -123,6 +124,7 @@ class Backdrop extends LitElement { | |||
| if (!reduceMotion && !this.noAnimateHide && isVisible(this)) { | |||
| this.addEventListener('transitionend', hide, { once: true }); | |||
| this._state = 'hiding'; | |||
| setTimeout(() => this._state === 'hiding' && hide(), TRANSITION_DURATION + 100); | |||
There was a problem hiding this comment.
So was transitionend just not firing in all cases?
There was a problem hiding this comment.
Whoops, thought I filled out the description more. Yeah it just doesn't fire, which is really weird. As far as I can tell transitioncancel also doesn't fire. The only thing I can think is there's some weird combo of low-CPU but also hardware acceleration going on where the timing just gets weird.
There was a problem hiding this comment.
Gotcha. There are likely a few other places where we do this, but they probably don't have such dire consequences if they're missed.
|
🎉 This PR is included in version 3.27.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
GAUD-6698: d2l-backdrop does not always clean up after itself