[PAUSED] Fix for predict file type when directory is provided as input #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Christian8491
changed the title
wmalpica
requested changes
Mar 29, 2021
| @@ -2296,6 +2287,28 @@ def create_table(self, table_name, input, **kwargs): | |||
| kwargs["names"].pop(id) | |||
| kwargs["dtype"].pop(id) | |||
|
|
|||
| # if the input is a directory and files do not have extension we want to raise an error | |||
| if name_file[-1] == "/" and extension == "": | |||
| all_files = os.listdir(name_file) | |||
There was a problem hiding this comment.
Something is wrong here. If we are creating a table from a folder, we will get the files listed out by the C++ layer. I cant remember where or how that happens, but the python layer cant be the one doing it. If you have an HDFS or S3 or GCS filesystem, python cant do os.listdir
Christian8491
changed the title
Christian8491
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1420