Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: auto-mode/debug-mode/notify instead of exit when done #813

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tschettervictor
Copy link
Collaborator

Implement "auto" mode -a
Implement "debug" mode -x

This will solve issues when templates have the PKG hook, and the hook fails for any reason. If it fails, the whole template command fails, which is sometimes not preferable. This will notify on error, but not exit, allowing the template to continue to run.

to test-

Run a template with PKG in it, forcing it to fail, perhaps with a wrong package name. It should fail the entire template command
Then with this PR it should just continue over to the next hook

@bmac2
Copy link
Collaborator

bmac2 commented Jan 17, 2025

but what good is a template that doesn't run correctly? What is the gain in it running with an error in it? I am struggling for the use case here.

@tschettervictor @yaazkal

@tschettervictor
Copy link
Collaborator Author

According to the discussion in #404 it seems we want a docker like method of continuing the template even if a command fails.

Correct me if I'm wrong.

@bmac2
Copy link
Collaborator

bmac2 commented Jan 20, 2025

per my reading of #404 @michael-o was saying to halt the template IF there is a missing parameter that the process halts and throws an error. NOT to cause the process to continue.

@michael-o am I misreading that issue?

@yaazkal @tschettervictor

@michael-o
Copy link
Contributor

per my reading of #404 @michael-o was saying to halt the template IF there is a missing parameter that the process halts and throws an error. NOT to cause the process to continue.

@michael-o am I misreading that issue?

@yaazkal @tschettervictor

Yes, totally correct, but I don't see any relation to this PR....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants