shellcheck: general linting and github action

[yaazkal]

This PR has two objectives:

1. Make a shellcheck linting on every new PR.
2. Clean the code using some suggestions of that linting in order to make the new PRs checks clean.

Relevant behavior that has been tested according to the changes:

• bootstrap.sh: Bootstraping linux jail (debian or ubuntu) in aarch64.
• clone.sh Clone VNET jail.
• common.sh VNET jail creation.
• convert.sh Convert a thin jail into a thick jail.
• create.sh Name sanity to not allow special characters.
• create.sh clone.
• destroy.sh destroying a jail (stopped or using -f).
• list.sh normal and using -a.
• stop.sh OK.
• export.sh conditional checks OK.
• import.sh OK.
• rdr.sh OK.
• rename.sh OK.
• service.sh OK.
• template.sh RENDER command OK, CP command OK.
• tags.sh OK.
• update.sh OK.
• verify.sh disabling some shellchecks here. OK.

Pending to test: mount

[yaazkal]

Can you help me test this @bmac2 ?

[tschettervictor]

What are you trying to accomplish with the templates command?
See PR #761

[yaazkal]

@tschettervictor nothing special in the template.sh here, just making a genereal linting to all the project and touching as little as possible in this PR in order to merge it later and have the linter in all the future PRs.

By the way, those PRs will be after this one, but I don't want to merge this until is well tested.

[tschettervictor]

Great! Looking forward to it. You'll notice I pushed quite a few PRs in the last few days addressing some bugs and features.

[yaazkal]

Great! Looking forward to it. You'll notice I pushed quite a few PRs in the last few days addressing some bugs and features.

Yes, thank you. I'll finish test this PR in order check those later this week/weekend

[tschettervictor]

Yes, thank you. I'll finish test this PR in order check those later this week/weekend

Anything I can do to help?

[yaazkal]

Anything I can do to help?

Sure, thanks. If you want to test this PR and give us feedback, that will be a great help. Mainly I'm running all the commands that I've touched to ensure nothing is broken (without taking into account other PRs of course).

Mainly could be typos that can breake something.

[tschettervictor]

You're referring to the bastille commands correct? Will see if I can go ahead and do that.

[yaazkal]

You're referring to the bastille commands correct? Will see if I can go ahead and do that.

yep, I've touched multiple bastille commands here, mainly quotes and syntax changes. I just want to be extra sure that nothing unwanted is going to happen later

[yaazkal]

Just updated the description of this issue with my tests, also made some extra commits fixing previous commits after the tests. Only mount has been not tested from my side, but feel pretty confident about this PR now. @bmac2 if you are ok with this you can merge it or let me know next steps.

This PR is blocking the review/merge of other PRs.