Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Draco encoding #16001

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

alexchuber
Copy link
Contributor

Add support for compressing meshes with Draco encoding. Introduces:

  • DracoEncoder class, with same usage pattern as DracoDecoder
  • Encoding options per mesh, with several new types to support this
  • New worker function and EncodeMesh() function in dracoCompressionWorker
  • Type files, separated by DracoEncoder and DracoDecoder, to avoid cluttering dracoCompressionWorker (while still avoiding cyclical dependencies)

I don't feel particularly content with dracoCompressionWorker-- both because encoding/decoding are present in the same file, and becauase I'm not sure that the worker functions must be separate. Please let me know of better ideas for this :)

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 16, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@alexchuber alexchuber requested a review from RaananW December 16, 2024 21:01
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 16, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 16, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 16, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 16, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 16, 2024

@alexchuber alexchuber requested a review from bghgary December 17, 2024 17:47
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the intent and feature !!! I ll let @RaananW and @bghgary comment more on it

@sebavan
Copy link
Member

sebavan commented Dec 20, 2024

cc @bghgary and I ll do the final review :-)

@sebavan sebavan marked this pull request as draft December 20, 2024 20:19
@sebavan
Copy link
Member

sebavan commented Dec 20, 2024

The PR will wait some checks with @RaananW next year :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants