Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202405] Added Change for given Route ECMP to fallback on Default Route ECMP #17

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

abdosi
Copy link

@abdosi abdosi commented Jan 8, 2025

What I did:

Cherry-pick of PR: sonic-net/sonic-swss#3389

@abdosi abdosi requested a review from prsunny as a code owner January 8, 2025 20:43
@abdosi abdosi requested a review from arlakshm January 8, 2025 20:44
@abdosi
Copy link
Author

abdosi commented Jan 8, 2025

@arlakshm pls help with signoff/review

@arlakshm
Copy link

arlakshm commented Jan 8, 2025

@abdosi the codeQL is failing with this error can you please check if this ok?

Switched to a new branch 'sonic'
error: patch failed: lib/route/route_obj.c:1201
error: lib/route/route_obj.c: patch does not apply
stg import: Diff does not apply cleanly

@prsunny prsunny changed the title Added Change for given Route ECMP to fallback on Default Route ECMP [202405] Added Change for given Route ECMP to fallback on Default Route ECMP Jan 8, 2025
@prsunny prsunny requested a review from bingwang-ms January 8, 2025 21:25
@prsunny
Copy link

prsunny commented Jan 8, 2025

@abdosi , can this be going to 202411 instead? Seems like a major change for 202405 branch. @bingwang-ms for viz. Is this dedicated repo?

@abdosi
Copy link
Author

abdosi commented Jan 8, 2025

@abdosi , can this be going to 202411 instead? Seems like a major change for 202405 branch. @bingwang-ms for viz. Is this dedicated repo?

yes @prsunny this PR is in sonic-swss.msft repo and will be used by Chassis only. We will not take this in 202405.

@arlakshm arlakshm merged commit 857dd6a into Azure:202405 Jan 8, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants