truncate logic correction in filecache #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. This is causing the network error when the file is large. Instead it passes the call to the next component.
syeleti-msft
requested review from
vibhansa-msft,
souravgupta-msft,
ashruti-msft and
jainakanksha-msft
as code owners
vibhansa-msft
approved these changes
Nov 18, 2024
souravgupta-msft
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ What
Modifying the truncate logic in filecache to prevent uploading the entire file.
🤔 Why
Current truncate op implemenation in filecache:
open, truncate, close ->which is causing a download, truncate then upload. If size to which we are truncating is large. this is causing network issue.
Current changes:
Pass the call to the next component to handle the truncate operation. This will prevent uploading entire file on the network.
🔖 Related links