fix: fixing HNS network already exist error in Stateless CNI #3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeZappa87
reviewed
Jan 2, 2025
behzad-mir
force-pushed
the
behzad-HNSNetwork
branch
from
bdaa36f to
859f4e4
Compare
| logger.Info("Successfully created hcn network with response", zap.Any("hnsResponse", hnsResponse)) | ||
| } else { | ||
| if strings.Contains(err.Error(), "already exists") { | ||
| // fetch the network name again since the parallel CNI Add call has created the HNS network |
There was a problem hiding this comment.
lets add a log printing err.Error() before calling get hns network
network/network_windows.go
Outdated
| if err != nil { | ||
| return nil, fmt.Errorf("Failed to get hcn network: %s due to error: %v", hcnNetwork.Name, err) | ||
| } | ||
| logger.Info("Successfully fetched hcn network with response", zap.Any("hnsResponse", hnsResponse)) |
There was a problem hiding this comment.
since you are logging whole struct, lets make sure its not printing any byte array
There was a problem hiding this comment.
Printed hnsreponse.ID instead in new commit
behzad-mir
force-pushed
the
behzad-HNSNetwork
branch
5 times, most recently
from
945e04f to
22e2cc8
Compare
behzad-mir
force-pushed
the
behzad-HNSNetwork
branch
from
22e2cc8 to
db1732b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR fix an issue in stateless CNI where the "HNS network already exists" error was not being handled correctly.
Since Stateless CNI add calls work in parallel, it is possible that two add process make API calls to create HNS netwrok at the same time and one of them fails since the other one successfully created the network (HNS process calls sequentially). In that case the second process should not exit in error and instead fetch the HNS network that was created by the first process and continue with the add call.
Notes: