Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PowerShell profile casing #303

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

JustinGrote
Copy link

@JustinGrote JustinGrote commented Mar 27, 2023

The powershell profile folders have incorrect casing (PowerShell instead of powershell) to the powershell default, and cause problems with scripts that interact with them. This PR fixes the casing.

Related Discussion: #302

@theJasonHelmick
Copy link
Member

@JustinGrote - thank you for this pr. Hey Justin - @bhavanakonchada and I are reviewing the change - Justin, can you change the conditional to the following logic?

If lowercase only exists - do nothing
If Pascal case only exists - rename to lowercase and add symlink PowerShell -> powershell
If both cases exists - do nothing since fix is already in

@bhavanakonchada
Copy link

@JustinGrote - thank you for this pr. Hey Justin - @bhavanakonchada and I are reviewing the change - Justin, can you change the conditional to the following logic?

If lowercase only exists - do nothing If Pascal case only exists - rename to lowercase and add symlink PowerShell -> powershell If both cases exists - do nothing since fix is already in

Adding to what @theJasonHelmick said, we need this change to avoid any disruption for existing customers as a lot could be riding on this path.

@JustinGrote
Copy link
Author

@bhavanakonchada @theJasonHelmick I added migration logic as appropriate and tried to handle all possible edge cases, I did not do this transparently as users should be informed what is going on.

@theJasonHelmick
Copy link
Member

Thank you @JustinGrote - much appreciated. Will review with @bhavanakonchada with the plan to accept the PR after testing.

@theJasonHelmick
Copy link
Member

Thank you @JustinGrote - much appreciated. Will review with @bhavanakonchada with the plan to accept the PR after testing.

I've delayed the review and merge of the PR to October 2023 post feature release for Ephemeral and UX2. Thank you for this fix - looking forward to have it included soon. WE may need to adjust the code for our own purposes, but the credit goes to you @JustinGrote for the catch and code. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants