Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate ARM team feedback into v2024-08-12-preview API version #4014

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Incorporate ARM team feedback into v2024-08-12-preview API version #4014

wants to merge 15 commits into from

Conversation

cadenmarchese
Copy link
Collaborator

@cadenmarchese cadenmarchese commented Dec 13, 2024 •
edited
Loading

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-13603 && https://issues.redhat.com/browse/ARO-13604

What this PR does / why we need it:

  • Removes syncSet, machinePool, syncIdentityProvider, secret from newest API version
  • Adds singleton GET endpoints for openShiftVersions && PlatformWorkloadIdentityRoleSets
  • Returns ID, Name, Type for proxy resources
  • Corrects plural (PlatformWorkloadIdentityRoleSet -> PlatformWorkloadIdentityRoleSets)
  • Updates generated clients (make client)

Test plan for issue:

  • CI and e2e
  • A canary deployment + cluster create should identify any issues

Is there any documentation that needs to be updated for this PR?

How do you know this will function as expected in production?

@cadenmarchese cadenmarchese mentioned this pull request Dec 16, 2024
Closed
@cadenmarchese cadenmarchese force-pushed the cadenmarchese/arm-review-part-2 branch from c4ef497 to aa21f59 Compare January 3, 2025 20:38
@cadenmarchese cadenmarchese added the chainsaw Pull requests or issues owned by Team Chainsaw label Jan 3, 2025
@cadenmarchese cadenmarchese marked this pull request as ready for review January 8, 2025 13:53
kimorris27
kimorris27 requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@kimorris27 kimorris27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few small suggestions, but mostly LGTM.

pkg/api/admin/platformworkloadidentityroleset_convert.go Show resolved Hide resolved
pkg/api/v20240812preview/platformworkloadidentityroleset_convert.go Show resolved Hide resolved
pkg/swagger/swagger.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajdeepc2792 rajdeepc2792 rajdeepc2792 left review comments

@kimorris27 kimorris27 kimorris27 approved these changes

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@petrkotas petrkotas Awaiting requested review from petrkotas petrkotas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@jaitaiwan jaitaiwan Awaiting requested review from jaitaiwan jaitaiwan is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel is a code owner

@hlipsig hlipsig Awaiting requested review from hlipsig hlipsig is a code owner

@mociarain mociarain Awaiting requested review from mociarain mociarain is a code owner

@tsatam tsatam Awaiting requested review from tsatam tsatam is a code owner

@bitoku bitoku Awaiting requested review from bitoku bitoku is a code owner

@fahlmant fahlmant Awaiting requested review from fahlmant fahlmant is a code owner

@sankur-codes sankur-codes Awaiting requested review from sankur-codes sankur-codes is a code owner

Assignees

@rajdeepc2792 rajdeepc2792

@tsatam tsatam

@cadenmarchese cadenmarchese

Labels
chainsaw Pull requests or issues owned by Team Chainsaw ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cadenmarchese @rajdeepc2792 @kimorris27 @tsatam