ARO-9395: Update fixssh to filter on Master subnet instead of NIC name #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lranjbar
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
lranjbar
changed the title
| pager := m.armInterfaces.NewListAllPager(opts) | ||
|
|
||
| masterSubnetID := m.doc.OpenShiftCluster.Properties.MasterProfile.SubnetID | ||
| // r, err := arm.ParseResourceID(masterSubnetID) |
There was a problem hiding this comment.
I don't think we should retain commented codes, best to delete if not used.
edisonLcardenas
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-9395
What this PR does / why we need it:
The existing function of "fixssh" filters on the NIC naming convention. With the addition of CPMS, the naming convention of NICs changes yet again. Instead of filtering on NIC naming convention. This changes the code to filter on whether or not the NIC is associated with the cluster's master subnet ID.
Test plan for issue:
Update unit tests and test in canary region
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?