Settings: Fix useSiteCopy features requesting selector

[tyxla]

Proposed Changes

Updates useSiteCopy hook to use the isRequestingSiteFeatures selector instead of building a custom one and returning a new object on every run.

This also improves the code quality: we already have a dedicated selector for this, so we should be using it.

Introduced previously in #72714.

Why are these changes being made?

To reduce the number of rerenders on the Settings > General page and resolve this warning:

Testing Instructions

• Go to /settings/general/:site where :site is a WP.com simple site.
• Verify the warning doesn't appear in your console.
• Go to /setup/copy-site/domains?sourceSlug=nonexistingweirdsite.wpcomstaging.com as per Copy site: add flow validation to check if sourceSlug is a valid site #72714.
• Verify the warning no longer appears in your console. The redirect to /sites is expected.

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130260

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130260&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130260&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~6 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
copy-site-flow       +181 B  (+0.0%)      +44 B  (+0.0%)
site-settings         -41 B  (-0.0%)      -10 B  (-0.0%)
settings              -41 B  (-0.0%)      -10 B  (-0.0%)
home                  -41 B  (-0.0%)      -28 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[jsnajdr]

Looks good. But an even better solution will be to finish #94840 🙂

The features.active field is already available on the site object, the features don't need to be fetched separately. #94840 also modifies useSiteCopy, you can see there how the code should eventually look like.

It turns out that the approach in #94840 is probably too ambitious: modify the siteHasFeature/getSiteFeatures selector, update the 30+ usage places to stop fetching, and test that none of them are broken.

We'll be better of doing something else: introduce new selectors, like siteHasFeatureEx and getSiteFeaturesEx, and start using these selectors at one place at a time. And do the migration gradually.

[tyxla]

Looks good. But an even better solution will be to finish #94840 🙂

The features.active field is already available on the site object, the features don't need to be fetched separately. #94840 also modifies useSiteCopy, you can see there how the code should eventually look like.

It turns out that the approach in #94840 is probably too ambitious: modify the siteHasFeature/getSiteFeatures selector, update the 30+ usage places to stop fetching, and test that none of them are broken.

We'll be better of doing something else: introduce new selectors, like siteHasFeatureEx and getSiteFeaturesEx, and start using these selectors at one place at a time. And do the migration gradually.

I agree 👍 One step at a time, and I always prefer small steps.

Thanks for taking a look!