Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve Username/Email When Switching to Password Login from Magic Link Flow #98582

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

okmttdhr
Copy link
Member

@okmttdhr okmttdhr commented Jan 20, 2025

Related to #

Proposed Changes

This PR fixes an issue where users must re-enter their username or email when switching from the "Email me a login link" view to the "Enter a password instead" view. Now, the previously entered username/email is retained in the input field, improving the user experience.

This fixes the partial of #53495. See #53495 (comment) for further improvement.

Why are these changes being made?

#53495

Testing Instructions

  • Go to /log-in.
  • Enter an email address or username and click "Continue."
    • Screenshot 2025-01-20 at 16 47 27
  • Click on "Email me a login link."
    • Screenshot 2025-01-20 at 16 48 06
  • Click on "Enter a password instead."
    • Screenshot 2025-01-20 at 16 48 36
  • The username/email field should now be pre-filled.
    • Screenshot 2025-01-20 at 16 49 11

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@okmttdhr okmttdhr self-assigned this Jan 20, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/magic-login-back-link on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~2 bytes removed 📉 [gzipped])

name         parsed_size           gzip_size
entry-login        -11 B  (-0.0%)       -2 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@okmttdhr okmttdhr requested a review from a team January 20, 2025 07:51
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 20, 2025
@okmttdhr okmttdhr marked this pull request as ready for review January 20, 2025 07:51
Copy link
Member

@madhusudhand madhusudhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes. It works as expected. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lego Maintenance [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants