Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Center: Fix article feedback in /sites #98537

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

escapemanuele
Copy link
Contributor

@escapemanuele escapemanuele commented Jan 17, 2025

Fixes https://github.com/Automattic/dotcom-forge/issues/10264

Proposed Changes

There is a bug in pages without a siteSlug, like /sites, where the buttons to contact support are not showed when clicking the thumbs down here at the end of an article:

image

This PR:

  • removes the check for site
  • adjust the styling of the buttons
  • fix the context for canConnectToZendesk not correct outside of Odie.
Before After
image image

Testing Instructions

  • Live Link
  • Open an article, reach the bottom and click on thumbs down
  • You should be able to see the buttons
  • Clicking on a button should bring you to the chat.

@escapemanuele escapemanuele requested a review from a team as a code owner January 17, 2025 11:24
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 17, 2025
@escapemanuele escapemanuele self-assigned this Jan 17, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix-feedback-article-contact on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~1 bytes added 📈 [gzipped])

name                                       parsed_size           gzip_size
async-load-automattic-help-center-stepper        +64 B  (+0.0%)       +1 B  (+0.0%)
async-load-automattic-help-center                +64 B  (+0.0%)       +1 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants