Skip to content

Commit

Permalink
better audio and dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
@ArjunSahlot
ArjunSahlot committed May 6, 2023
1 parent 6c982d1 commit 395c60a
Show file tree
Hide file tree
Showing 4 changed files with 89 additions and 78 deletions.
7 changes: 6 additions & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,13 @@ video = piano_visualizer.Video((1920, 1080), 30)
video.add_piano(piano)

# Export video on multiple cores (1 for single)
video.export("your/export/path.mp4", 6)
video.export("your/export/path.mp4", num_cores=6)

# You can add music too! (although it is sometimes offset from video)
# video.export("your/export/path.mp4", num_cores=6, music=True)

# Progress bars should show up
# Once your video is exported it will be at the path you specified!
```

NOTE: For music to work, you need [fluidsynth](https://github.com/FluidSynth/fluidsynth/wiki/Download)
Binary file added example.mp4
View file
Binary file not shown.
158 changes: 81 additions & 77 deletions piano_visualizer/__init__.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,11 @@
import pygame
import shutil
import time
import sys
import mido
import multiprocessing
import ctypes
import ffmpeg
import threading
from moviepy.editor import VideoFileClip, concatenate_videoclips
from notifypy import Notify
from midi2audio import FluidSynth
from random_utils.colors.conversions import hsv_to_rgb
from random_utils.funcs import crash
from pydub import AudioSegment
Expand All @@ -53,7 +51,15 @@ def set_audio(self, audio, overwrite=True):
else:
self.audio.append(audio)

def export(self, path, num_cores=4, notify=True, **kwargs):
def export(self, path, num_cores=4, music=False, notify=True, **kwargs):
"""
Export the video to the given path.
:param path: destination to where the video will be
:param num_cores: number of cores to use for exporting, defaults to 4
:param music: whether or not you want music (it is usually not aligned with video unfortunately), defaults to False
:param notify: notify the user through a system notification when exporting is done, defaults to True
"""
if "frac_frames" in kwargs:
frac_frames = kwargs["frac_frames"]
else:
Expand Down Expand Up @@ -116,8 +122,7 @@ def quick_export(core, start, end):
num_cores = min(num_cores, multiprocessing.cpu_count())
processes = []
curr_frame = 0
frame_inc = (frames + self.start_offset +
self.end_offset) / num_cores
frame_inc = (frames + self.start_offset + self.end_offset) / num_cores

print(
f"Exporting {int(frame_inc)} on each of {num_cores} cores...")
Expand Down Expand Up @@ -167,58 +172,64 @@ def quick_export(core, start, end):
print(f"Finished in {round(time.time()-time_start, 3)} seconds.")
print("Releasing video...")

millisecs = (frames + 1)/self.fps * 1000
sounds = []
print("Creating music...")
for audio_path in self.audio:
if audio_path == "default":
for i, piano in enumerate(self.pianos):
sounds.extend(piano.gen_wavs(export_dir, millisecs))
else:
sounds.append(AudioSegment.from_file(
audio_path, format=audio_path.split(".")[-1])[0:millisecs])
print("Created music.")

print("Combining all audios into 1...")
music_file = os.path.join(export_dir, "piano.wav")
sound = sounds.pop(sounds.index(max(sounds, key=lambda x: len(x))))
for i in sounds:
sound = sound.overlay(i)

# Compress audio to length of video
new_sound = sound._spawn(sound.raw_data, overrides={
"frame_rate": int(sound.frame_rate*(len(sound)/millisecs))})
new_sound.set_frame_rate(sound.frame_rate)

new_sound.export(music_file, format="wav")
print("Done")

if self.start_offset or self.end_offset:
print("Offsetting music...")
s_silent = AudioSegment.silent(
self.start_offset/self.fps * 1000)
e_silent = AudioSegment.silent(self.end_offset/self.fps * 1000)
(s_silent + AudioSegment.from_wav(music_file) +
e_silent).export(music_file, format="wav")
print("Music offsetted successfully")

print("Compiling video")
video = ffmpeg.input(os.path.join(export_dir, "video.mp4")).video
audio = ffmpeg.input(music_file).audio
video = ffmpeg.output(
video, audio, path, vcodec="copy", acodec="aac", strict="experimental")
if os.path.isfile(path):
os.remove(path)
ffmpeg.run(video)
if music:
millisecs = (frames + 1)/self.fps * 1000
sounds = []
print("Creating music...")
for audio_path in self.audio:
if audio_path == "default":
for i, piano in enumerate(self.pianos):
sounds.extend(piano.gen_flac(export_dir, millisecs))
else:
sounds.append(AudioSegment.from_file(
audio_path, format=audio_path.split(".")[-1])[0:millisecs])
print("Created music.")

print("Combining all audios into 1...")
music_file = os.path.join(export_dir, "piano.flac")
sound = sounds.pop(sounds.index(max(sounds, key=lambda x: len(x))))
for i in sounds:
sound = sound.overlay(i)

sound.export(music_file, format="flac")
# Compress audio to length of video
# new_sound = sound._spawn(sound.raw_data, overrides={"frame_rate": int(sound.frame_rate*(len(sound)/millisecs))})
# new_sound.set_frame_rate(sound.frame_rate)

# new_sound.export(music_file, format="flac")
print("Done")

if self.start_offset or self.end_offset:
print("Offsetting music...")
s_silent = AudioSegment.silent(
self.start_offset/self.fps * 1000)
e_silent = AudioSegment.silent(self.end_offset/self.fps * 1000)
(s_silent + AudioSegment.from_file(music_file, "flac") + e_silent).export(music_file, format="flac")
print("Music offsetted successfully")

print("Compiling video")
video = ffmpeg.input(os.path.join(export_dir, "video.mp4")).video
audio = ffmpeg.input(music_file).audio
video = ffmpeg.output(
video, audio, path, vcodec="copy", acodec="aac", strict="experimental")
if os.path.isfile(path):
os.remove(path)
ffmpeg.run(video)
else:
print("Skipping music...")
os.rename(os.path.join(export_dir, "video.mp4"), path)

print(f"Video Done")
print("Cleaning up...")

except (Exception, KeyboardInterrupt) as e:
print(f"Export interruputed due to {e}")
print(f"Export interrupted due to {e}")
shutil.rmtree(export_dir)
if sys.platform == "linux" and notify:
os.system(
f"notify-send 'Piano Visualizer' 'Export interrupted due to {e}'")
if notify:
notification = Notify()
notification.title = "Piano Visualizer"
notification.message = f"Export interrupted due to {e}"
notification.send()
crash()

shutil.rmtree(export_dir)
Expand All @@ -227,9 +238,11 @@ def quick_export(core, start, end):
f"Finished exporting video in {total_time//60} mins and {round(total_time%60, 3)} secs.")
print("-"*50)

if sys.platform == "linux" and notify:
os.system(
f"notify-send 'Piano Visualizer' 'Finished exporting {path.split('/')[-1]}'")
if notify:
notification = Notify()
notification.title = "Piano Visualizer"
notification.message = f"Finished exporting {path.split('/')[-1]}"
notification.send()

def render(self, frame):
surf = pygame.Surface(self.resolution, pygame.SRCALPHA)
Expand Down Expand Up @@ -277,17 +290,15 @@ def configure(self, datapath, value):
def render_rect(self, surf, x, y, width, height, color):
s = pygame.Surface((width, height), pygame.SRCALPHA)
for cy in range(int(height+1)):
pygame.draw.rect(s, list(color) +
[255*((height-cy)/height)], (0, cy, width, 1))
pygame.draw.rect(s, list(color) + [255*((height-cy)/height)], (0, cy, width, 1))
surf.blit(s, (x, y))

def render(self, surf, frame, y, width, height, wheight, bheight, wwidth, bwidth, gap):
counter = 0
playing_keys = self.get_play_status(frame)
black_keys = []
if self.blocks:
self.render_blocks(surf, frame, y, width, height -
wheight, wwidth, bwidth, gap)
self.render_blocks(surf, frame, y, width, height - wheight, wwidth, bwidth, gap)
py = y + height - wheight
surf.fill((0, 0, 0), (0, py, width, wheight))

Expand All @@ -309,8 +320,7 @@ def render(self, surf, frame, y, width, height, wheight, bheight, wwidth, bwidth
x, width) if self.color == "rainbow" else self.white_hit_col
else:
color = self.white_col
pygame.draw.rect(surf, self.white_col,
(x, py, wwidth, wheight))
pygame.draw.rect(surf, self.white_col, (x, py, wwidth, wheight))
self.render_rect(surf, x, py, wwidth, wheight, color)

for key in black_keys:
Expand Down Expand Up @@ -355,7 +365,7 @@ def parse_midis(self):
frame = 0
start_keys = [None] * 88
for msg in track:
frame += msg.time/midi.ticks_per_beat * tempo/1000000 * self.fps
frame += msg.time/midi.ticks_per_beat * tempo/1675000 * self.fps
if msg.is_meta:
if msg.type == "set_tempo":
tempo = msg.tempo
Expand Down Expand Up @@ -383,20 +393,14 @@ def get_min_time(self):
def get_max_time(self):
return max(self.notes, key=lambda x: x["end"])["end"]

def gen_wavs(self, export_dir, silent_len):
wavs = []
wav_path = os.path.join(export_dir, "pianowav.wav")
def gen_flac(self, export_dir, silent_len):
flacs = []
flacs_path = os.path.join(export_dir, "pianoflac.flac")
for midi in self.midis:
os.system(f"timidity {midi} -Ow -o {wav_path}")
try:
wavs.append(a := AudioSegment.from_wav(wav_path))
except FileNotFoundError:
print(
"You might not have timidity installed on your machine.", file=sys.stderr)
print(
"Please have that installed if you are using the midi files as audio.", file=sys.stderr)
return [AudioSegment.silent(silent_len)]
return wavs
fs = FluidSynth()
fs.midi_to_audio(midi, flacs_path)
flacs.append(AudioSegment.from_file(flacs_path, format="flac"))
return flacs

def register(self, fps, offset):
self.fps = fps
Expand Down
2 changes: 2 additions & 0 deletions requirements.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@ random-utils
ffmpeg-python
pydub
tqdm
notify-py
midi2audio

0 comments on commit 395c60a

Please sign in to comment.