Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Folder #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

abheektripathy
Copy link

this solves #11

@RoguedBear
Copy link
Contributor

github actions file may also need to be updated to reflect the new dockerfile paths

# https://github.com/marketplace/actions/push-to-ghcr
- name: Build and publish a Docker image for ${{ github.repository }}
uses: macbre/push-to-ghcr@master
with:
image_name: ${REPO_LC}-backend
image_tag: ${{ env.TAG }}
github_token: ${{ secrets.GITHUB_TOKEN }}
# optionally push to the Docker Hub (docker.io)
# docker_io_token: ${{ secrets.DOCKER_IO_ACCESS_TOKEN }} # see https://hub.docker.com/settings/security
# https://github.com/marketplace/actions/push-to-ghcr
- name: Build and publish a Docker image for ${{ github.repository }}
uses: macbre/push-to-ghcr@master
with:
dockerfile: Dockerfile.celery
image_name: ${REPO_LC}-celery-backend
image_tag: ${{ env.TAG }}
github_token: ${{ secrets.GITHUB_TOKEN }}
# optionally push to the Docker Hub (docker.io)
# docker_io_token: ${{ secrets.DOCKER_IO_ACCESS_TOKEN }} # see https://hub.docker.com/settings/security

@abheektripathy abheektripathy changed the base branch from develop to master October 31, 2022 09:54
@@ -36,6 +36,7 @@ jobs:
- name: Build and publish a Docker image for ${{ github.repository }}
uses: macbre/push-to-ghcr@master
with:
#dockerfile: Docker/Dockerfile
Copy link
Contributor

@RoguedBear RoguedBear Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part may actually have to be uncommented, otherwise the action may look for Dockerfile in the repository root location and not the Docker/ folder.

you can check these changes work or result in error by manually triggering the action.

you can do that by visiting the actions tab in your fork and you will see a button "Run workflow" from which you can manually trigger the docker build action (below image is from my fork's action tab)

image

@abheektripathy
Copy link
Author

well well, looks like this is still open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants