Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing breadcrumbs #551

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sboldyreva
Copy link
Contributor

Navigation enhancements:

  • 2 new files added to add and generate breadcrumbs: docs/.vuepress/breadcrumbs.js and docs/.vuepress/enhanceApp.js
  • Updated docs/.vuepress/config.js to include breadcrumb logic
  • Updated docs/.vuepress/styles/index.styl for the breadcrumbs style
  • Wiki pages updated to define the hierarchy for each file:
    • Define parent(1 level), grandparent (2 level), child (3 level)
    • For each 'hierarchy directory' definition in docs/.vuepress/breadcrumbs.js:
      • path - if there's path
      • linkable - true or false

Display examples:
image
image
image

Copy link
Member

@bennyvasquez bennyvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great from my perspective! The only additional request I have is that you open an issue to add documentation for this addition for anyone that adds more pages later on, so it's clear what we need to do if we're adding high-level pages and subpages in the future.

@bennyvasquez
Copy link
Member

Before we merge this, I'd like someone from @AlmaLinux/infrastructure-sig to make sure that we can still auto-deploy this. I'm not anticipating any problems, but I don't wanna break things on a Friday. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants