Fix false positive for single or double quotes that are safely escaped #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timokoessler
reviewed
Jan 6, 2025
| #[test] | ||
| fn test_partial_match_single_quote() { | ||
| let starts_with = r#" | ||
| SELECT "foo" WHERE "bar" = '''; sleep 15 ;"' |
There was a problem hiding this comment.
let's add is injection cases
| // However, if the user input is `'value` and the single quote is escaped with another single quote | ||
| // `'value` becomes `'''value'` in the query so we still find an exact match | ||
| // (vice versa for double quotes) | ||
| if userinput.contains("'") || userinput.contains('"') { |
kapyteinaikido
approved these changes
Jan 7, 2025
The start of the string, the double quote to escape the next double quote, the actual double quote of the user input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a partial match