-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Windows Linux subsystem shell and Cygwin bash #21
base: master
Are you sure you want to change the base?
Conversation
lheinman
commented
Jul 22, 2019
- Created a Powershell script to convert file path provided by IntelliJ to *nix format.
- Updated README.md to reflect changes in IntelliJ keyboard shortcuts configuration.
- Provided a workaround for a Cygwin's curl problem: unable to open files in absolute paths, such as /tmp
Fixes for Windows Linux subsystem shell and Cygwin bash
Updated README.md, moved code around
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lheinman Thanks for the contribution!
A few requests & comments inline.
Clirified use of Cygwin in the wrapper script; wrapper code cleanup
Renamed repoWrapper to repoWin; reverted some of repoWin code cleanup
Moved backslash flipping code into 'repo' bash shell script to enable using 'repo' from Cygwin bash directly
|
||
$cmdPath = $cmdPath -replace '\\','/' | ||
$cmdPath = $cmdPath -replace '.:','/mnt/c' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why this logic can't be in repo
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting this code in repo
results in stripping all backslashes. For path
:
repo: does not exist: C:DevgitDigitalPlatformuisrcmaincontentjcr_rootappschipotlecomponentsstructurepagev1pagepartialsgascript.html
for cmdPath
:
/bin/bash: C:githubtoolsrepo/repo: No such file or directory