Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Windows Linux subsystem shell and Cygwin bash #21

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

lheinman
Copy link

  • Created a Powershell script to convert file path provided by IntelliJ to *nix format.
  • Updated README.md to reflect changes in IntelliJ keyboard shortcuts configuration.
  • Provided a workaround for a Cygwin's curl problem: unable to open files in absolute paths, such as /tmp

Copy link
Contributor

@alexkli alexkli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lheinman Thanks for the contribution!

A few requests & comments inline.

repo/README.md Show resolved Hide resolved
repo/repo Show resolved Hide resolved
repo/repoWrapper.ps1 Outdated Show resolved Hide resolved
lheinman-chipotle-com and others added 3 commits July 23, 2019 22:41
Moved backslash flipping code into 'repo' bash shell script to enable using 'repo' from Cygwin bash directly

$cmdPath = $cmdPath -replace '\\','/'
$cmdPath = $cmdPath -replace '.:','/mnt/c'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this logic can't be in repo too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting this code in repo results in stripping all backslashes. For path:
repo: does not exist: C:DevgitDigitalPlatformuisrcmaincontentjcr_rootappschipotlecomponentsstructurepagev1pagepartialsgascript.html
for cmdPath:
/bin/bash: C:githubtoolsrepo/repo: No such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement waiting for response Waiting for a response from the reporter(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants