Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mary and Abinnet #20

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

Mary and Abinnet #20

wants to merge 63 commits into from

Conversation

mmlamkin
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C9/VideoStoreConsumer-API#15
For each person in your pair, describe something you learned from your partner during this project Mary- I learned more about containers and working with form components.
Abinnet- I learned more about how to pass info between components using state and containers and styling
What was one area of React you gained more clarity on during this assignment? Mary-I feel more comfortable with callback functions after this project
Abinnet- Passing info between components via callbacks and props and state with containers has improved.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We used the images to allow for visual representation
Describe how you handled rentals with React We changed the state of app so we could statically display the title of movie and name of customer with buttons with callback functions in customer and movie. The API post call is in app as well.
Describe a DOM event your application handled Clicks and didmount we showed content or more buttons to allow for functionality. Eg waiting to show buttons to rent a movie until after the movies show up
Did you use any functional stateless components? What for? We did not have any functional stateless components in our working code.
Did you use any container components? What for? We did but ended up removing them because we found it easier to use a single parent component that both acted as a component and container . Ex search functionality we have search form also contain the component for search results.
Do you have any recommendations on how we could improve this project for the next cohort? maybe spending some more time on containers and functional stateless components. Maybe also a little reminder or more work within the project working with the rails api

mmlamkin and others added 30 commits June 18, 2018 13:23
… search results to app and other components added some validations and removed unused variables
… local api unsuccessfully but without crashing the react page
Abiaina and others added 30 commits June 19, 2018 16:47
…values until page is rendered again. Copied app search components into search container..future place to refactor
…cted. still unable to have post request to addmovie to lib
…e disappear from external api search page after hitting add to library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants