Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brenda Rios - Trek - Octos #30

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

brendarios
Copy link

@brendarios brendarios commented May 29, 2018

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? Asynchronous code means that it will be executed at some point in the future, often in response to some external event. We can change of task even without finishing the other one.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? All depends on click events and what the user clicks.The user can load all the trips and click on a specific trip to view additional details.
What kind of errors might the API give you? How did you choose to handle them? The user is notified if the reservation failed if the API didn't accept the POST request.
Do you have any recommendations on how we could improve this project for the next cohort? Good intro after some few days on jquery.

@droberts-sea
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes
Functionality
Click a button to list trips yes
Click a trip to see trip details yes
Fill out a form to reserve a spot yes
Errors are reported to the user yes
Styling yes
Under the Hood
Trip data is retrieved using from the API yes
JavaScript is well-organized and easy to read mostly - see inline
HTML is semantic yes
Overall Excellent job overall! This code is for the most part well-organized and easy to read, and it's clear the learning goals of this assignment were met. I especially appreciate the care you put into error handling. I've left a couple inline comments for you to review below, but in general I am quite happy with this submission. Keep up the hard work!


reportStatus(`Successfully loaded trip to: ${response.data.name}`);

trip.append(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to break the code to render trip details out into a separate function - as is, this function is doing two things (making the request, and rendering data). See also http://callbackhell.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants