Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers - Mariko #26

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Ampers - Mariko #26

wants to merge 6 commits into from

Conversation

marikoja
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It runs at different times, you can send a request and continue to run other code while you wait for the response.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? The calls to the API run asynchronously we added message to the user to let them know what was going on.
What kind of errors might the API give you? How did you choose to handle them? Errors are handled in the catch of the API response. The user is provided with an error message
Do you have any recommendations on how we could improve this project for the next cohort?

@tildeee
Copy link

tildeee commented Jun 6, 2018

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
Functionality
Click a button to list trips x
Click a trip to see trip details x
Fill out a form to reserve a spot
Errors are reported to the user
Styling x
Under the Hood
Trip data is retrieved using from the API x
JavaScript is well-organized and easy to read
HTML is semantic a lot of divs... not worried... almost worried though
Overall

I know I didn't get to grade this project on time-- we've talked this through in person. That being said:

Oh no Mariko! This project wasn't completed.

You were missing

  • reserving
  • displaying error messages

I've also made a few comments on the code style

That being said, hopefully things have turned around for you now with JavaScript and APIs. Let me know what questions you have, though.

index.js Outdated
const URL = 'https://ada-backtrek-api.herokuapp.com/trips';

const reportStatus = (message) => {
$('status-message').html(message);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This selector $('status-message') looks for an element <status-message> ... if you wanted the ID of that, you'd use $('#status-message')

index.js Outdated
};

const clearForm = () => {
reservationFromFields.forEach((field) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be mindful... reservationFromFields used here is different than the reservationFORMFields you defined up above because spelling... ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants