Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers: Alex #25

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Ampers: Alex #25

wants to merge 15 commits into from

Conversation

brownav
Copy link

@brownav brownav commented May 28, 2018

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? Asynchronous code is not fixed in terms of run order, some parts maybe be executed before other parts are finished running.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? Trip details are displayed for a given trip depending on which trip the user selects to view, however all trips are not reloaded for each new trip details request.
What kind of errors might the API give you? How did you choose to handle them? If an api url request is invalid, errors will be thrown, for example, when there is a field missing for making a reservation request. I called errors in the .catch portion of in case the api call promise is unfulfilled.
Do you have any recommendations on how we could improve this project for the next cohort? Tips on how to elegantly render bulk HTML after a function call.

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits and good commit messages
Comprehension questions Check, normally we use templating engines for large blocks of HTML (good question BTW). You can look up underscore templates for more.
Functionality
Click a button to list trips Check
Click a trip to see trip details Check
Fill out a form to reserve a spot Check
Errors are reported to the user You are reporting errors but not including details about validation errors like we did in class.
Styling Basic styling, no responsiveness at all
Under the Hood
Trip data is retrieved using from the API Check
JavaScript is well-organized and easy to read Pretty neatly organized
HTML is semantic Good semantic HTML
Overall Nice work, you hit all the learning goals. Things to work on include making sure you display info on validation error messages, and making your site responsive.

<script src="https://code.jquery.com/jquery-3.3.1.js"></script>
<script type="text/javascript" src="index.js"></script>
<script src="https://unpkg.com/axios/dist/axios.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.14.3/umd/popper.min.js" integrity="sha384-ZMP7rVo3mIykV+2+9J3UJ46jBk0WLaUAdn689aCwoqbBJiSnjAK/l8WvCWPIPm49" crossorigin="anonymous"></script>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, but I didn't see you using popper.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants