Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers: Nora Peters #43

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Ampers: Nora Peters #43

wants to merge 13 commits into from

Conversation

npeters5
Copy link

@npeters5 npeters5 commented May 18, 2018

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? There were a lot of similar patterns I borrowed from my Ruby knowledge, and the Ruby implementation of Scrabble, including the use of a constant to hold the letter/point key/value pairs, various conditionals and iterations, as well as patterns related to scope of things like variables and instance methods.
What was a challenge you faced in this assignment? Getting used to new javascript syntax and of course writing tests; however, since the tests were stubbed and the test syntax isn't too complex (and the program itself wasn't super complex), the test writing was manageable.
Do you have any recommendations on how we could improve this project for the next cohort? Nope, keep on keepin on!

@CheezItMan
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits and good commit messages
Comprehension questions Check, glad you found familiar patterns and that you found the project manageable.
General
score calculates score, has appropriate params and return value Check
highestScoreFrom calculates highest scoring word, has appropriate params and return value Check
Player object
Has name and plays properties Check
Has play, totalScore, hasWon functions Check
Has highestScoringWord and highestWordScore functions Check
Overall Well done, you hit all the major learning goals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants