Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers - Maddie Shields #41

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Ampers - Maddie Shields #41

wants to merge 3 commits into from

Conversation

madaleines
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? following if/else statements, checking inclusion of letters in arrays
What was a challenge you faced in this assignment? highest score
Do you have any recommendations on how we could improve this project for the next cohort? atm, no

@CheezItMan
Copy link

CheezItMan commented May 20, 2018

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Not many git commits, good commit messages
Comprehension questions Check
General
score calculates score, has appropriate params and return value Check, with one bug, see my inline note
highestScoreFrom calculates highest scoring word, has appropriate params and return value MISSING
Player object
Has name and plays properties Missing plays attribute
Has play, totalScore, hasWon functions MISSING
Has highestScoringWord and highestWordScore functions MISSING
Overall You definitely struggled here. It's disappointing that you didn't get the past the highestScoreFrom method. When you're getting blocked you need to get help either from a classmate myself or Dee, a TA or Charles. Don't try to just slip by. It's normal to struggle, but you don't do yourself any favors by not addressing problems. You don't let yourself get stuck on one thing too long. We'll talk about it on Monday.

this.word = word;
// Need to test for invalid 'word'
// if (!/^[a-zA-Z]+$/.test(word)) {
if (!word.match(/^[a-zA-z]+$/)) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look at the A-z, it should be A-Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants