-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ampers: Katie #30
base: master
Are you sure you want to change the base?
Ampers: Katie #30
Conversation
…ensitive inputs, and removed skips from the remaining test within that describe block
…on passes all tests, including empty string and a word longer than 7 characters
…crabble object to pass all tests, likely needs major refactor, very bulking now
…logic around name attribute and edit test suite to run tests for Player constructor
…stubbed out remaining function name into the Player class
…asic logic to remaining functions in Player to test manually without test suite for now
… all tests, commented out remaining logic in methods with no written tests to try to at least simulate tdd
…call the method to debug
…were one line functions and checked and hopefully added any missing ; to the code
…of the forEach loops into one and shorten the method
JS ScrabbleWhat We're Looking For
Looks good! I'm thrilled you practiced arrow function syntax a bunch! It looks great! If I had time to refactor, I'd want to figure out a way to move away from the giant if/else if block in Otherwise good work overall |
shortestIndex = index; | ||
} | ||
} | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see here you have mapped arrayOfWords
into an equally-sized array of scores into scores
... This means that you need to reliably work in parallel between two arrays (which is how you use index
).
I haven't explored this deeply myself, but I would want to explore having an array of objects that contain a word and a score...
Just a thought for maybe a future refactoring!
JS Scrabble
Congratulations! You're submitting your assignment!
Comprehension Questions