Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers: Katie #30

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Ampers: Katie #30

wants to merge 14 commits into from

Conversation

kcforsman
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I feel like conditional statements (although different syntax) are pretty much the same in javascript as in ruby. I also feel like I ended up coding a very similar solution to my partner and mine solution to the Ruby Scrabble we did earlier this cohort. Setting variables to check for certain expectations and find correct returns then iterating through an array with a forEach loop in JavaScript feels very similar to using an each loop in Ruby.
What was a challenge you faced in this assignment? Not forgetting the syntactic nuances of Javascript that don't quite mesh with habits formed by Ruby. Using this and not self when I needed to call on a the current instance
Do you have any recommendations on how we could improve this project for the next cohort? I would have possibly liked to have seen more tests to work with for writing them instead of having so many already done (personally). In the end the test structure seems very similar to Ruby so having the opportunity to practice the syntax differences, especially with how quickly we need to run through JavaScript would be my preference.

kcforsman added 14 commits May 15, 2018 15:20
…ensitive inputs, and removed skips from the remaining test within that describe block
…on passes all tests, including empty string and a word longer than 7 characters
…crabble object to pass all tests, likely needs major refactor, very bulking now
…logic around name attribute and edit test suite to run tests for Player constructor
…stubbed out remaining function name into the Player class
…asic logic to remaining functions in Player to test manually without test suite for now
… all tests, commented out remaining logic in methods with no written tests to try to at least simulate tdd
…were one line functions and checked and hopefully added any missing ; to the code
…of the forEach loops into one and shorten the method
@tildeee
Copy link

tildeee commented May 23, 2018

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
General
score calculates score, has appropriate params and return value x
highestScoreFrom calculates highest scoring word, has appropriate params and return value x
Player object
Has name and plays properties x
Has play, totalScore, hasWon functions x
Has highestScoringWord and highestWordScore functions x
Overall

Looks good!

I'm thrilled you practiced arrow function syntax a bunch! It looks great!

If I had time to refactor, I'd want to figure out a way to move away from the giant if/else if block in score().

Otherwise good work overall

shortestIndex = index;
}
}
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see here you have mapped arrayOfWords into an equally-sized array of scores into scores... This means that you need to reliably work in parallel between two arrays (which is how you use index).

I haven't explored this deeply myself, but I would want to explore having an array of objects that contain a word and a score...

Just a thought for maybe a future refactoring!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants