&&: Mariko and Monalisa's Scrabble #7

MonalisaC · 2018-02-23T23:27:36Z

Scrabble

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature	Feedback
What are the advantages of using git when collaboratively working on one code base?	We can both see and make changes to the same document.
Why do you think we chose to make the `score` method in the `Scoring` class a class method instead of an instance method?	So that it can be used in all instance of the class.
Describe an example of a test you wrote for a nominal case.	We wrote a test for draw tiles to check if it returns a collection of random tiles.
Describe an example of a test you wrote for an edge case.	For Scoring.score we did an edge case like returns nil for string containing bad characters .
Does your code use any methods from the `Enumerable` mixin? If so, where and why was it helpful?	In Scoring#highest_score_from we used some enumerables like map, max it is more concise and short.
What was one method you and your pair used to debug code?	Used puts statement to debug.
Is there a specific piece of code you'd like feedback on?	More examples of edge cases
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	Trying to figure out the best way to communicate with each other. Different processing process while working in pair.

Merge branch 'master' of https://github.com/MonalisaC/Scrabble

…test passing

Merge branch 'master' of https://github.com/MonalisaC/Scrabble

CheezItMan · 2018-02-27T21:57:17Z

Scrabble

What We're Looking For

Feature	Feedback
General
Answered comprehension questions	Check, for the class methods we made them such because the methods aren't tied to a particular instance of a class and they don't really fit a `Player` action.
Both Teammates contributed to the codebase	Both teammates contributed commits.
Regular Commits with meaningful commit messages	Good number of commits and good commit mesages
Scoring class
`score` method	Check
Uses appropriate data structure to store the letter score	Check
Appropriately handles edge cases	Check
`highest_score_from` method	Check, nicely done.
Appropriately handles edge cases	Check
Test implementations for `highest_score_from`	See my notes
Player class
Uses an array to keep track of words played	Check
Uses existing code to create `highest_scoring_word` and `highest_word_score`	Check, nicely done
Returns `true` or `false` from `won?` method	Check
Tests edge cases on the `play(word)`	Check, see my notes however.
TileBag class
Uses a data structure to keep the set of default tiles in the bag	Well done
`draw_tiles` method uses the parameter to draw a set of random tiles	Check
`tiles_remaining` method returns a count	Check
Tests `draw_tiles` edge cases	Missing some edge cases
Summary	Well done, you used a lot of enumerables, and caught most of the tricky things with Scrabble. See my notes, but overall well done!

CheezItMan · 2018-02-27T21:37:43Z

lib/scoring.rb

+        return total
+      end
+
+      def self.pick_winner(highest_scoring_words)


Nice a helper method! Good use of min_by.

CheezItMan · 2018-02-27T21:38:18Z

lib/scoring.rb

+        return highest_scoring_words.min_by { |word| word.length }
+      end
+
+      def self.highest_scoring_words(array_of_words)


Good use of Enumerables.

CheezItMan · 2018-02-27T21:38:43Z

lib/scoring.rb


-    def self.highest_score_from(array_of_words)
+      def self.highest_score_from(array_of_words)


Very neat how you broke this down.

CheezItMan · 2018-02-27T21:41:51Z

lib/scoring.rb

+      # letters is a array of upcase letters
+      letters = word.upcase.chars.to_a
+
+      letters.map{ | letter |


You don't need map here, map is used to convert an array to something else. If you wanted to use map you could:

scores = letters.map do |letter| CHART[letter.toupcase] end return scores.sum

CheezItMan · 2018-02-27T21:44:23Z

specs/scoring_spec.rb

    end

    it 'returns the only word in a length-1 array' do
+      Scrabble::Scoring.highest_score_from(['BANJO']).must_equal 'BANJO'
    end

    it 'returns the highest word if there are two words' do


Good job swapping the order!

CheezItMan · 2018-02-27T21:48:37Z

specs/player_spec.rb

+    end
+
+
+    it  'Adds the input word to the plays Array' do


What about playing words, after the player has won?

CheezItMan · 2018-02-27T21:51:08Z

specs/player_spec.rb

+
+    it "Fills tiles array, after player uses the tiles" do
+      player.draw_tiles(tilebag)
+      word = player.tiles.join


CheezItMan · 2018-02-27T21:54:03Z

lib/tilebag.rb

+  class TileBag
+    attr_reader :tiles
+    def initialize
+      @tiles = ["A"] * 9 + ["B"] * 2 + ["C"] * 2 + ["D"] * 4 + ["E"] * 12 + ["F"] * 2 + ["G"] * 3 + ["H"] * 2 + ["I"] * 9 + ["J"] * 1 +["K"] * 1 + ["L"] * 4 + ["M"] * 2 + ["N"] * 6 + ["O"] * 8 + ["P"] * 2 + ["Q"] * 1 +["R"] * 6 + ["S"] * 4 + ["T"] * 6 + ["U"] * 4 + ["V"] * 2 + ["W"] *2 +["X"] * 1 + ["Y"] * 2 + ["Z"] * 1


Awesome data structure here.

CheezItMan · 2018-02-27T21:54:36Z

specs/tilebag_spec.rb

+
+describe 'TileBag' do
+
+  let(:tilebag) {Scrabble::TileBag.new}


Nice use of a let

CheezItMan · 2018-02-27T21:55:29Z

specs/tilebag_spec.rb

+      tilebag.draw_tiles(0).length.must_equal 0
+
+    end
+    it "removes the tiles from the default set" do


An edge-case would be drawing more tiles than exist in the bag.

marikoja and others added 30 commits February 20, 2018 14:28

Add data structure to Scrabble::Scoring, all tests scoring

00eb474

Add data structure to Scrabble::Scoring, all tests failing

54a4ce2

Add data structure to Scrabble::Scoring, all tests failing

f859160

Fixed typo

4e9690d

Fixed typos in game.rb file

50e6e8f

Merge branch 'master' of https://github.com/MonalisaC/Scrabble

113b217

Add code for Scrabble::Scoring.score method and all tests passing

5966556

Removed (word.class) != String from Scoring.score method

d9bd5a0

Added tests for highest_score_from method, all tests failing

2666fa8

"Added tests for highest_score_from method, all tests failing"

1be4781

Merge branch 'master' of https://github.com/MonalisaC/Scrabble

Added code for highest_score from method and fixed bug in test...all …

79abcb6

…test passing

Refactored code in Scoring class

5622cc3

Add files for player class

e5f022b

Wrote test for Player initialize method

f390f5d

Wrote tests for play word method

4579839

Add Test for Player class total Score method

91f5629

Added test for #won? method

d77c640

Added tests for #highest_scoring_word and #highest_word_score

96afa17

Add edge cases for #highest_scoring_word and #highest_word_score

c881386

Add code for Player#initialize#play#total_score#won?

996c1ac

Added code for player#highest_score_from method, all tests passing

733b1a5

Added code for player#highest_word_score, all tests passing

957fe34

created tilebag_spec file, added initialize tests.

d498069

Skeleton for class TileBag and Add initialize method

24b62da

Added describe blocks for #tilesdrawn and #tilesremaining

2a17ef9

Corrected initialize tiles

0aad21e

Merge branch 'master' of https://github.com/MonalisaC/Scrabble

4f6fe64

Fixed typos

21873ac

Added all tests for initialize and fixed bugs in tests

9c8370d

Add tests for TileBag#draw_tiles, TileBag#tiles_remaining method

bd02cde

marikoja and others added 6 commits February 23, 2018 12:16

added code for #draw_tiles and #tiles_remaining

deee180

#draw_tiles(tile_bag) test and code added, all tests passing

4a8324b

Added raise argument error to player word method, all tests passing

0709584

Added raise argument error to player play method

314c27d

Refactored code and added more tests, All tests passing.

840d596

Refactored code and added more tests, All tests passing.

93c09e2

Merge branch 'master' of https://github.com/MonalisaC/Scrabble

CheezItMan reviewed Feb 27, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

&&: Mariko and Monalisa's Scrabble #7

&&: Mariko and Monalisa's Scrabble #7

MonalisaC commented Feb 23, 2018

CheezItMan commented Feb 27, 2018

CheezItMan Feb 27, 2018

CheezItMan Feb 27, 2018

CheezItMan Feb 27, 2018

CheezItMan Feb 27, 2018

CheezItMan Feb 27, 2018

CheezItMan Feb 27, 2018

CheezItMan Feb 27, 2018

CheezItMan Feb 27, 2018

CheezItMan Feb 27, 2018

CheezItMan Feb 27, 2018


		def self.highest_score_from(array_of_words)
		def self.highest_score_from(array_of_words)

&&: Mariko and Monalisa's Scrabble #7

Are you sure you want to change the base?

&&: Mariko and Monalisa's Scrabble #7

Conversation

MonalisaC commented Feb 23, 2018

Scrabble

Comprehension Questions

CheezItMan commented Feb 27, 2018

Scrabble

What We're Looking For

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment