Ana Lisa & Jamila: Octos-C9 #21

The-Beez-Kneez · 2018-02-25T19:40:05Z

Scrabble

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature	Feedback
What are the advantages of using git when collaboratively working on one code base?	It is easy for people to consider the problem separately on different screens.
Why do you think we chose to make the `score` method in the `Scoring` class a class method instead of an instance method?	So that the overall module Scrabble would be able to access Scoring Class elsewhere in the program
Describe an example of a test you wrote for a nominal case.	We tested whether or not the plays method could return an array.
Describe an example of a test you wrote for an edge case.	We had some drafted up for won but did not get the chance to implement them.
Does your code use any methods from the `Enumerable` mixin? If so, where and why was it helpful?	We used inject to receive the total_score of our player's word scores.
What was one method you and your pair used to debug code?	We utilized pry pretty heavily and relied on our tests for the majority of the project.
Is there a specific piece of code you'd like feedback on?	Any and all is welcome.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We both agreed that we worked well together and felt that we were able to discuss ideas and plans on an equal footing. However two individual points held us back, we should have asked for help early on and agreed in the future that if we are stuck, instead of toughing it out, we should ask for help after 20 minutes have gone by.

droberts-sea · 2018-03-02T00:57:18Z

Scrabble

What We're Looking For

Feature	Feedback
General
Answered comprehension questions	yes
Both Teammates contributed to the codebase	yes
Regular Commits with meaningful commit messages	yes
Scoring class
`score` method	yes
Uses appropriate data structure to store the letter score	yes
Appropriately handles edge cases	yes
`highest_score_from` method	yes
Appropriately handles edge cases	tie breaking doesn't work - see inline
Test implementations for `highest_score_from`	see inline
Player class
Uses an array to keep track of words played	yes
Uses existing code to create `highest_scoring_word` and `highest_word_score`	some - methods have othr problems
Returns `true` or `false` from `won?` method	yes
Tests edge cases on the `play(word)`	some - see inline
TileBag class
Uses a data structure to keep the set of default tiles in the bag	N/A
`draw_tiles` method uses the parameter to draw a set of random tiles	N/A
`tiles_remaining` method returns a count	N/A
Tests `draw_tiles` edge cases	N/A

The big learning goals I'm looking to see demonstrated on this project are:

Building complex logic (tie-breaking logic in highest_score_from)
Test coverage
Object composition (interaction between Player and TileBag)

You've made a good start on all of these, but there are substantial pieces missing for each. Please review my inline comments, and try and focus on these learning goals for Ride Share and next week's Hotel project. I'll be excited to see what you come up with. I appreciate that both of you have been putting in the hours recently - keep up the hard work and dedication!

droberts-sea · 2018-02-26T02:42:57Z

lib/scoring.rb

+    LETTER_VALUES =
+    {
+      :A => 1,
+      :E => 1,


I like this choice of data structure!

droberts-sea · 2018-02-26T02:45:33Z

lib/scoring.rb

+        # iterate over each letter
+        user_word.each do |letter|
+          letter = letter.to_sym
+          if LETTER_VALUES.has_key?(letter)


This check on line 52 is redundant! Above (line 36) you do a regex match, and here you check whether the LETTER_VALUES hash contains the letter. One or the other would suffice. I think I prefer the check here, since that makes it easy if you ever need to change the letters (maybe our version of scrabble starts allowing words with apostrophes).

droberts-sea · 2018-02-26T02:46:59Z

lib/scoring.rb

+        # RETURNS WORD FROM ARRAY LENGTH 1
+      elsif array_of_words.length == 1
+        return array_of_words[0]
+      else


Since both the if and elsif branches of this conditional have a return, you can omit the else entirely. It's not a huge difference, but it saves you some indentation.

droberts-sea · 2018-02-26T03:02:17Z

specs/scoring_spec.rb

    end

    it 'if tied, prefer a word with 7 letters' do
+      array_of_words = ['dog', 'course', 'lungers']
+      Scrabble::Scoring.highest_score_from(array_of_words).must_equal 'lungers'
    end


Since lungers gets the 7-letter bonus, I don't think you actually have a tie here. There isn't a pair of English words that allow you to test this logic, but zzzzzz and oratory will do.

"Why bother" you ask? Well, if Miriam-Webster adds zzzzzz as an onomatopoeia for snoring, we need to be prepared, or you could envision a scrabble app that works across languages or that allows users to add their own words. Moreover, maybe this is the mathematician in me speaking, but I believe there's beauty and joy to be found in writing code that isn't just "good enough", but which truly solves the problem.

droberts-sea · 2018-02-26T03:03:52Z

specs/scoring_spec.rb

    end

    it 'returns the highest word if there are two words' do
+      array_of_words = ['cat', 'zoo']
+      Scrabble::Scoring.highest_score_from(array_of_words).must_equal 'zoo'


It might be wise to reverse the order of this array and check that you get the same result. You would be surprised at how often this sort of thing turns up a bug. This applies to all the tiebreaker tests in this section.

droberts-sea · 2018-02-26T03:28:46Z

lib/player.rb

+      # if word_scores.include?(nil)
+      #   binding.pry
+      # end
+      return word_scores.inject(:+)


droberts-sea · 2018-02-26T03:29:54Z

lib/player.rb

+      end
+
+      def highest_scoring_word
+        Scrabble::Scoring.highest_score_from(plays)


You're missing an end here - highest_scoring_word is defined inside of won. Turns out this is valid Ruby syntax, but it'd probably not what you wanted.

droberts-sea · 2018-02-26T03:30:58Z

lib/player.rb

+      if total_score > 100
+        return true
+      else
+        return false


Since > will always return true or false, this could be shortened to:

def won? return total_score > 100 end

droberts-sea · 2018-02-26T03:36:46Z

specs/player_spec.rb

+  describe 'won?' do
+    it 'if player has > 100 point score, return true' do
+      word = "crazy"
+      word_1 = 'janky'


Here are some other questions I would like to see answered by these tests:

What if the player has not played any words at all?

What if the player has < 100 points?

What if the player has exactly 100 points?

droberts-sea · 2018-02-26T03:37:06Z

specs/player_spec.rb

+
+      # Assert
+      player.total_score.must_be Integer
+


You should also calculate the score and check the result.

The-Beez-Kneez and others added 18 commits February 20, 2018 15:04

Al's starting self.score

85baafb

lib/scoring.rb

890c4a9

Invalid Chars done, greater then 7 done, add 50 for seven

b4a90d4

passed first test of highest_score_from method

6e806fd

test 1 and two passing for highest_score_from method

520d5d8

We have work to do on the 7 tile score, but so far progress

cd3b543

Spec file changes

472c4ac

two test passed for method highest_score_from

6a5244a

fixed tie scenarios for method highest_score_from

14a3628

finished wave one

98b1f47

Started Player Class, and passed tests for name and plays

3398167

tests refactor

6d9038b

Created Play Test

12d5110

created two more play tests and empty won method

23d2d56

Wrote Tests For Won/No Code/Tests Currently Not Passing

8773008

refactored play method and test, still needs work

e2a6ec7

play method working

a41ad3c

highest scoring word test not passing

2771c57

droberts-sea reviewed Mar 2, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ana Lisa & Jamila: Octos-C9 #21

Ana Lisa & Jamila: Octos-C9 #21

The-Beez-Kneez commented Feb 25, 2018 •

edited by droberts-sea

Loading

droberts-sea commented Mar 2, 2018

droberts-sea Feb 26, 2018

droberts-sea Feb 26, 2018

droberts-sea Feb 26, 2018

droberts-sea Feb 26, 2018

droberts-sea Feb 26, 2018

droberts-sea Feb 26, 2018

droberts-sea Feb 26, 2018

droberts-sea Feb 26, 2018

droberts-sea Feb 26, 2018

droberts-sea Feb 26, 2018

Ana Lisa & Jamila: Octos-C9 #21

Are you sure you want to change the base?

Ana Lisa & Jamila: Octos-C9 #21

Conversation

The-Beez-Kneez commented Feb 25, 2018 • edited by droberts-sea Loading

Scrabble

Comprehension Questions

droberts-sea commented Mar 2, 2018

Scrabble

What We're Looking For

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

The-Beez-Kneez commented Feb 25, 2018 •

edited by droberts-sea

Loading