&&: Aruna & Kate

[Oh-KPond]

Scrabble

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature	Feedback
What are the advantages of using git when collaboratively working on one code base?	It was helpful for creating sandboxes for our code, as well as being able to use our own environments/computers. It helped if we ever wanted to go back to a previous state.
Why do you think we chose to make the score method in the Scoring class a class method instead of an instance method?	A class method can be used for all instances instead of just one instance or "player". Since a game has many players, the score should be accessible to all of those players.
Describe an example of a test you wrote for a nominal case.	The nominal cases, for example, were those that checked to see if the player responded to play or name.
Describe an example of a test you wrote for an edge case.	We did write an edge case for the player play method to make sure that a player could not enter a word that includes special characters.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful?	We did use max_by and min_by to help with the code that decided a winner when there was a tie. It was helpful because it cut down on code that needed to be changed, and made the code base less bulky.
What was one method you and your pair used to debug code?	We used the ruby gem Awesome Print a lot to see what our variable outputs were, and Minitest was great to see where errors were happening.
Is there a specific piece of code you'd like feedback on?	We would like to see feedback on testing and how that can be done better.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	When we were thinking about the code, but not pair programming, it was great to use Slack as a way to communicate and give feedback about our ideas. We really thought it was important that we were open with each other throughout the program so that that we could remind ourselves of how we had originally planned to grow.

[CheezItMan]

Scrabble

What We're Looking For

Feature	Feedback
General
Answered comprehension questions	Check, I'm glad it sounds like you worked well together.
Both Teammates contributed to the codebase	Check
Regular Commits with meaningful commit messages	Check, good commit messages and regular commits
Scoring class
score method	Check
Uses appropriate data structure to store the letter score	There is a more efficient way to do this, consider a hash.
Appropriately handles edge cases	Check
highest_score_from method	Check
Appropriately handles edge cases	You need to consider invalid words
Test implementations for highest_score_from	See my in-code notes, you also need to write tests to ensure the order isn't causing a word to win despite another rule.
Player class
Uses an array to keep track of words played	Check
Uses existing code to create highest_scoring_word and highest_word_score	Check
Returns true or false from won? method	Check, but see my notes in your code.
Tests edge cases on the play(word)	Some
TileBag class
Uses a data structure to keep the set of default tiles in the bag	Check, good data structure, but poor choice in how you remove tiles from the bag.
draw_tiles method uses the parameter to draw a set of random tiles	You are calling draw_tiles as if it's a class method and not an instance method. See my incode notes.
tiles_remaining method returns a count	NOT WORKING
Tests draw_tiles edge cases	You tried, but they're failing.
Summary	You hit most of the learning goals. You need to look more closely at your TileBag class and how tiles are being drawn, you're on the right track, but need more testing and more work on draw_tiles

[CheezItMan]

In these tests you should also vary up the order, just to make sure the order of the elements isn't determining the answer.

      Scrabble::Scoring.highest_score_from(["dog", "rooster"]).must_equal "rooster"
     Scrabble::Scoring.highest_score_from(["rooster", "dog"]).must_equal "rooster"

Also what about testing a list of words with an invalid word in the mix.

[CheezItMan]

This works, but is there a more compact way to do this using a hash?

[CheezItMan]

Good, now what about an invalid word in the list?

[CheezItMan]

This should not be an accessor.

[CheezItMan]

Each player should NOT receive their own TileBag. Instead use the parameter provided to draw_tiles.

[CheezItMan]

won? shouldn't fail if the user doesn't call total_score first.

[CheezItMan]

You're not testing the draw_tiles method!

[CheezItMan]

This isn't working

[CheezItMan]

You're calling draw_tiles like a class method, not an instance method of tilebag

Should be:

tilebag.draw_tiles(num)

[CheezItMan]

This test is failing

[CheezItMan]

If you're just going to return 1 word, why push array_of_words into winning_word_array instead return array_of_words[0]