Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maja Graonic Octos (wave 2/3 pending) #38

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Maja Graonic Octos (wave 2/3 pending) #38

wants to merge 7 commits into from

Conversation

mgraonic
Copy link

@mgraonic mgraonic commented May 1, 2018

No description provided.

@kariabancroft
Copy link

MediaRanker Revisted

What We're Looking For

Feature Feedback
General
Tests on WorksController Yes - though you didn't finish it, i'm glad you considered the different behaviors for being logged in vs not logged in
Tests on SessionsController Yes - some
Tests on UsersController No
Completed OAuth Yes
Overall Don't forget to always put your coverage report folder in the .gitignore so you don't check it in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgraonic @kariabancroft