Octos- Ari- MediaRanker Revisited

[arrriiii]

No description provided.

[droberts-sea]

MediaRanker Revisted

What We're Looking For

Feature	Feedback
General
Tests on WorksController	mostly
Tests on SessionsController	mostly
Tests on UsersController	mostly
Completed OAuth	yes
Overall	From a high level the tests you've written look good, and it seems like your concept of what to test is on track. However, because your tests weren't running they ended up drifting out of sync with your code, and once I fixed the root problem many of them were failing. In the future, this is exactly the sort of thing it would be wise to seek instructor help on, since 10 minutes of searching on my part might prevent many hours of you being stuck. Even on a weekend I'm pretty good about responding to Slack messages.

[droberts-sea]

You've also added require_login as a filter on the ApplicationController, which means it will happen before every single controller action. Your line 5 here adds it again for everything but root, but doesn't take it away for root. Instead it should be a skip_before_action for only :root.

This is also why all your WorksController tests were breaking.

This was a tricky one - it took me a while to figure out what was going on 🙂