Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Erika #41

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 45 additions & 6 deletions lib/linked_list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,36 +10,75 @@ def initialize
# Time complexity - ?
# Space complexity - ?
Comment on lines 10 to 11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No guesses on time/space complexity?

def add_first(data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


@head = Node.new(data, @head)
end

# Time complexity - ?
# Space complexity - ?
def get_first

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


if @head == nil
return nil
else
return @head.data
end
end

# Time complexity - ?
# Space complexity - ?
def length

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return 0
curr = @head
count = 0
until curr == nil
count += 1
curr = curr.next
end
return count
end

# Time complexity - ?
# Space complexity - ?
def add_last(data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


curr = @head
if @head == nil
@head = Node.new(data)
else
until curr.next == nil
curr = curr.next
end
curr.next = Node.new(data)
end
end

# Time complexity - ?
# Space complexity - ?
def get_last

curr = @head

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if head is nil?

Suggested change
curr = @head
return nil if @head.nil?
curr = @head

if @head == nil
return nil
else
until curr.next == nil
curr = curr.next
end
return curr.data
end
end

# Time complexity - ?
# Space complexity - ?
def get_at_index(index)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about if the index is greater than the length of the list?


count = 0
curr = @head
if @head == nil
return nil
elsif index == 0
return @head.data
else
until count == index || curr.next == nil
curr = curr.next
count += 1
end
end
return curr.data
end

end
14 changes: 10 additions & 4 deletions test/linked_list_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
end
end

xdescribe 'add_first & get_first' do
describe 'add_first & get_first' do
it 'can add values to an empty list' do
# Act
@list.add_first(3)
Expand Down Expand Up @@ -51,7 +51,7 @@
end
end

xdescribe "length" do
describe "length" do
it "will return 0 for an empty list" do
expect(@list.length).must_equal 0
end
Expand All @@ -66,12 +66,18 @@
end
end

xdescribe "addLast & getLast" do
describe "addLast & getLast" do

it "will add to the front if the list is empty" do
@list.add_last(1)
expect(@list.get_first).must_equal 1
end

it "will return nil if the list is empty" do
expect(@list.get_last).must_be_nil
end


it "will put new items to the rear of the list" do
@list.add_last(2)
expect(@list.length).must_equal 1
Expand All @@ -91,7 +97,7 @@

end

xdescribe 'get_at_index' do
describe 'get_at_index' do
it 'returns nil if the index is outside the bounds of the list' do
expect(@list.get_at_index(3)).must_be_nil
end
Expand Down