-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branches - Farah #33
base: master
Are you sure you want to change the base?
Branches - Farah #33
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -1,4 +1,5 @@ | ||||||||
require_relative 'node' | ||||||||
require 'pry' | ||||||||
|
||||||||
class LinkedList | ||||||||
attr_reader :head | ||||||||
|
@@ -7,39 +8,72 @@ def initialize | |||||||
@head = nil | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(1) where 1 is the one node created | ||||||||
# Space complexity - O(1) where 1 is the one node created in space | ||||||||
Comment on lines
+11
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually it's O(1) because the amount of time and memory doesn't change no matter how big the list is. |
||||||||
def add_first(data) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||||||||
|
||||||||
@head = Node.new(data, head) | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(1) because it is grabbing the first node in the list | ||||||||
# Space complexity - O(1) because it is returning one node | ||||||||
def get_first | ||||||||
|
||||||||
return nil if head.nil? | ||||||||
return @head.data | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(n) where n is the length of the linked list | ||||||||
# Space complexity - O(1) because only a single number is being returning, the length of the list | ||||||||
def length | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||||||||
return 0 | ||||||||
count = 0 | ||||||||
current = @head | ||||||||
until current.nil? | ||||||||
count += 1 | ||||||||
current = current.next | ||||||||
end | ||||||||
return count | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(n) where n is the length of the entire list | ||||||||
# Space complexity - O(1) because you are adding one node | ||||||||
def add_last(data) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||||||||
current = @head | ||||||||
|
||||||||
if current.nil? | ||||||||
add_first(data) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good re-use of a method |
||||||||
return | ||||||||
end | ||||||||
|
||||||||
until current.next == nil | ||||||||
current = current.next | ||||||||
end | ||||||||
current.next = Node.new(data) | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(n) where n is the length of the entire list | ||||||||
# Space complexity - O(1) because you are returning informatio on one node | ||||||||
def get_last | ||||||||
current = @head | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if
Suggested change
|
||||||||
until current.next == nil | ||||||||
current = current.next | ||||||||
end | ||||||||
|
||||||||
return current.data | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(n) where n is the length of the list, in worst case scenario | ||||||||
# Space complexity - O(1) because only single node data is returned | ||||||||
def get_at_index(index) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if the index is greater than the length of the list? |
||||||||
current = @head | ||||||||
if current.nil? | ||||||||
return nil | ||||||||
end | ||||||||
|
||||||||
i = 0 | ||||||||
while i != index | ||||||||
i += 1 | ||||||||
current = current. next | ||||||||
end | ||||||||
|
||||||||
return current.data | ||||||||
end | ||||||||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove pry on submission