Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branches - Diana Han #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Branches - Diana Han #31

wants to merge 2 commits into from

Conversation

dhan0406
Copy link

@dhan0406 dhan0406 commented Dec 9, 2019

Linked List Comprehension Questions

Question Response
1. What advantages does a LinkedList have over an Array? Insertion and deletion of a node is much easier in a linked list. This is because the memory is dynamically allocated (non-contiguous) and therefore nodes can be anywhere in memory.
2. When is an Array more advantageous? Searching for an element is faster because we can use its indices which use contiguous memory.

CheezItMan
CheezItMan reviewed Dec 18, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, you definitely hit the learning goals here. Well done. You do however have one bug in the final method. Take a look at my comments and let me know any questions you have.

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def add_first(data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def get_first
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def length
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def add_last(data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
def get_last
return nil if @head.nil?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def get_last
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def get_at_index(index)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if index is greater than the length of the list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhan0406 @CheezItMan