Leaves - Bri #27
Open
Leaves - Bri #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Dec 18, 2019
| def add_first(data) | ||
|
|
||
| node = Node.new(data, nextNode = @head) |
There was a problem hiding this comment.
Suggested change
| node = Node.new(data, nextNode = @head) | |
| node = Node.new(data, @head) |
| # Space complexity - ? | ||
|
|
||
| # Time complexity - O(1) | ||
| # Space complexity - O(1) | ||
| def add_first(data) |
| # Space complexity - ? | ||
|
|
||
| # Time complexity - O(1) | ||
| # Space complexity - O(1) | ||
| def get_first |
| # Space complexity - ? | ||
|
|
||
| # Time complexity - O(n) | ||
| # Space complexity - O(1) | ||
| def length |
| # Space complexity - ? | ||
|
|
||
| # Time complexity - O(n) | ||
| # Space complexity - O(1) | ||
| def add_last(data) |
| def add_last(data) | ||
|
|
||
| node = Node.new(data, nextNode = nil) | ||
| if @head == nil |
| def get_last | ||
|
|
||
| last_node = @head |
There was a problem hiding this comment.
What if head is nil?
Suggested change
| last_node = @head | |
| return nil if head.nil? | |
| last_node = head |
| # Space complexity - ? | ||
|
|
||
| # Time complexity - O(n) | ||
| # Space complexity - O(1) | ||
| def get_at_index(index) |
There was a problem hiding this comment.
What if index is greater than the length of the list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked List Comprehension Questions