Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches: Mira, Sara, Momo, C. Gutierrez #95

Open
wants to merge 285 commits into
base: master
Choose a base branch
from

Conversation

CEsGutierrez
Copy link

bEtsy

Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.

Comprehension Questions

Question Answer
Each team member: what is one thing you were primarily responsible for that you're proud of? Mk- products controller, tests, reviews // Sb- user controller,category controller,dashboard and validation test for user. // Mg - adding editing removing items from cart, order fulfillment // cG - User validation at the time of purchase
Each team member: what is one thing you were primarily responsible for that you would like targeted feedback on? Mk- Tests? // Sb- dashboard // Mg - persisting the cart for guest users // cG - more systematic test writing for improved coverage
How did your team break up the work to be done? We took certain models/controllers and became primarily responsible for those features and functionality.
How did your team utilize git to collaborate? We did lots of pr’s to retrieve each others code so that we could utilize that for our own features.
What did your group do to try to keep your code DRY while many people collaborated on it? Refactoring was not always on our mind. But we did do comments to communicate to each other what codes were working and not working or work in progress.
What was a technical challenge that you faced as a group? Git hygiene and git glitches
Reading other people’s codes and not braking it by accident
What was a team/personal challenge that you faced as a group? Git hygiene - we had large pr’s which created a lot of reading and held back some code that other teammates could use. At the halfway point, we decided to have better hygiene which helped improve our group work flow. Week 2 stand-ups were sit-downs...because standing up was a challenge
What was your application's ERD? (include a link) Stand up notes: https://docs.google.com/document/d/1xsSPnWTN8odBuNXkALo_Pi5N18Rv2L5KVBKfWnlZIOg/edit Controller erd: https://drive.google.com/drive/folders/1psty4BQJSk20uOHGDzQ7AXpQJ4D-jT-p Attr erd: https://drive.google.com/drive/folders/1psty4BQJSk20uOHGDzQ7AXpQJ4D-jT-p
What is your Trello URL? https://trello.com/b/2WtuxE1e/cave-of-wonders
What is the Heroku URL of your deployed application? https://branchy-cave-of-wonders.herokuapp.com/https://branchy-cave-of-wonders.herokuapp.com/
--


@cart.date_time_order_purchased = DateTime.now

@cart.date_time_order_purchased
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line doesn't do anything. This line queries for @cart's attribute of date_time_order_purchased, but doesn't actually execute any commands or do anything. I want to make sure that your team gets some understanding about why this line doesn't do anything soon; come see me!

@cart.date_time_order_purchased
@order_items = @cart.order_items

@order_items.each do |order_item|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring everything inside of this .each block into a model method in OrderItem is a good opportunity for refactoring!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants