-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branches: Mira, Sara, Momo, C. Gutierrez #95
base: master
Are you sure you want to change the base?
Conversation
fixes fixture relation syntax
Fixed catgeory display on add product form
Vendor facing style
Gitignore cov folder
Updated prod controller tests
merge commit.
form edited
Tiny style
|
||
@cart.date_time_order_purchased = DateTime.now | ||
|
||
@cart.date_time_order_purchased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line doesn't do anything. This line queries for @cart
's attribute of date_time_order_purchased
, but doesn't actually execute any commands or do anything. I want to make sure that your team gets some understanding about why this line doesn't do anything soon; come see me!
@cart.date_time_order_purchased | ||
@order_items = @cart.order_items | ||
|
||
@order_items.each do |order_item| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactoring everything inside of this .each
block into a model method in OrderItem
is a good opportunity for refactoring!
bEtsy
Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.
Comprehension Questions