Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support matplotlib version 3.10.x #891

Merged
merged 4 commits into from
Dec 31, 2024
Merged

support matplotlib version 3.10.x #891

merged 4 commits into from
Dec 31, 2024

Conversation

schaubh
Copy link
Contributor

@schaubh schaubh commented Dec 30, 2024

  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

With matplotlib version 3.10.x some scripts were causing new errors and warnings. This branch updates the scripts to work with 3.10.x, and also still works with 3.9.x.

Verification

All tests pass, documentation built without issues.

Documentation

Updated release notes

Future work

None

@schaubh schaubh added bug Something isn't working documentation Improvements or additions to documentation labels Dec 30, 2024
@schaubh schaubh requested a review from Mark2000 December 30, 2024 19:52
@schaubh schaubh self-assigned this Dec 30, 2024
@schaubh schaubh requested a review from a team as a code owner December 30, 2024 19:52
@schaubh schaubh force-pushed the feature/matplotlib_3_10 branch from 86b67c8 to 3131611 Compare December 30, 2024 21:48
Copy link
Contributor

@Mark2000 Mark2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Starting with matplotlib 3.10 this caused an error.
Some test scripts were creating specific figures multiple times even tough only one case was tested at a time.
All test scripts pass again without matplotlib errors and warnings.  Running with matplotlib 3.9.4 also works without issue.
@schaubh schaubh force-pushed the feature/matplotlib_3_10 branch from 3131611 to 3708665 Compare December 31, 2024 19:25
@schaubh schaubh merged commit 65796ad into develop Dec 31, 2024
9 checks passed
@schaubh schaubh deleted the feature/matplotlib_3_10 branch December 31, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants