1.0 fixes, adds ability to monitor multiple servers, and future save file #22
Conversation
|
Thanks for this @featheredtoast. I'm overall happy with the proposed changes and the rational, there's just one doc block to add. |
|
Just pushed a few fixes, wanted more stuff configurable via env vars. gonna test a little more but it's looking good now. will update docs. |
|
just updating, FRM has a few more updates to make it more 1.0 compatible, so I'll update this PR with those. Meanwhile, would you mind terribly much if we updated how readme generation is done? From what I understand, we're using a golang template to generate the table, and then a batch script to search+replace the readme template... Can we update this to just use golang templates through-and-through? That way I'd be able to generate new readme tables on non-windows, which is my primary daily driver |
featheredtoast
force-pushed
the
monitor-multiple
branch
from
43e8941 to
75b6250
Compare
|
Yeah I'm completely fine with that. I don't use Windows for anything anymore, so I really should update the tooling full stop. (Apols for the very slow reply. I wanted to wait until you'd finished making the changes you were making ... then I forgot I was waiting) |
|
All good, I think I'm almost done here, FRM 1.2(?) has become much more stable and I don't anticipate this mod needing too many more changes on this. I'll ping you once I update the tooling steps and then this should be good to merge in |
allow recording metrics based on url and save name
FRM is changing to normalize on the name CircuitGroupID
group metrics to drop by common labels. additionally, unregister all metrics on save name change
drop all train and vehicle data on session name change
…ected timing metrics
pull in powerinfo with max power stats and use this rather than hardcode values. pull in power info into train station platforms and add those up.
no need to calculate this anymore
Update readme templating to use go template. Switch to text/template.
featheredtoast
force-pushed
the
monitor-multiple
branch
from
1a52cc8 to
c31e297
Compare
|
@AP-Hunt I believe this is in a good state now |
|
Thanks for all your work on this @featheredtoast. I don't have the capacity to test these changes, so I'm going to have to trust that they work. I've reviewed the non-FRM specific bits though, and I'm happy with them. I'll merge this and cut a release. |
Allow for collections to parameterize server name and save file.
Add new -hostnames arg that is a comma separated value list of servers to watch and update, EG
-hostnames server1:8080,server2:9090,server3:8080- this is exposed as aurllabel to metrics so interested parties can watch multiple servers at once.save_namelabel is "default" for now until FRM can provide a save name.Also fix up some discrepancies with ficsit remote monitoring's values. We still do not have power values back yet but they're coming