Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add VBT and EC blob support #82

Merged
merged 4 commits into from
Nov 2, 2023
Merged

feat: add VBT and EC blob support #82

merged 4 commits into from
Nov 2, 2023

Conversation

AtomicFS
Copy link
Collaborator

@AtomicFS AtomicFS commented Oct 27, 2023 •
edited
Loading

Contains quite important fixes:

  • dockerfile was missing a dependency
  • not sure exactly why, but WithMountedDirectory started to cause problems when nested. So replaced it with WithDirectory for the blobs.

@AtomicFS AtomicFS added feature New feature or request github actions labels Oct 27, 2023
@AtomicFS AtomicFS force-pushed the feat/add_vbt_and_ec branch 3 times, most recently from 4744141 to 5654f84 Compare October 31, 2023 10:02
@AtomicFS AtomicFS marked this pull request as ready for review October 31, 2023 10:12
@AtomicFS AtomicFS requested a review from MDr164 October 31, 2023 10:12
@AtomicFS AtomicFS added this to the Refactor the Go action milestone Oct 31, 2023
@AtomicFS AtomicFS enabled auto-merge October 31, 2023 10:12
@AtomicFS AtomicFS force-pushed the feat/add_vbt_and_ec branch 2 times, most recently from f5e3681 to 925b3ee Compare October 31, 2023 16:07
@AtomicFS AtomicFS added the bugfix Bugfix / fix label Oct 31, 2023
@AtomicFS AtomicFS force-pushed the feat/add_vbt_and_ec branch from 925b3ee to 8b26361 Compare November 1, 2023 15:09
@AtomicFS
feat: add VBT and EC blob support
448fdce
@AtomicFS
fix(dockerfile): add missing dependency
e73b1f6
@AtomicFS
fix(action): create destination directory for mounting
c464b78 
- create a destination directory when mounting blobs which are actually
  directories
- for dagger WithMountedDirectory the destination must exist
@AtomicFS
fix(action): switch from WithMountedDirectory to WithDirectory
bf6aa3a 
- WithMountedDirectory has problems when nested
- since working directory in container is already mounted with
  WithMountedDirectory, the subsequent mounts would silently fail
  resulting only in empty directories
@AtomicFS AtomicFS force-pushed the feat/add_vbt_and_ec branch from 8b26361 to bf6aa3a Compare November 2, 2023 09:21
@AtomicFS
Copy link
Collaborator Author

AtomicFS commented Nov 2, 2023

@MDr164 review?

@AtomicFS AtomicFS added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit ef048b0 Nov 2, 2023
25 checks passed
@AtomicFS AtomicFS deleted the feat/add_vbt_and_ec branch November 2, 2023 13:06
@AtomicFS AtomicFS added github_actions Pull requests that update GitHub Actions code and removed github actions labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDr164 MDr164 MDr164 approved these changes

Assignees
No one assigned
Labels
bugfix Bugfix / fix feature New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
Refactor the Go action
Development

Successfully merging this pull request may close these issues.
2 participants
@AtomicFS @MDr164