test: coreboot version passing #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
AtomicFS
force-pushed
the
test/coreboot-version-passing
branch
from
0b27ef8 to
f1d7b1d
Compare
AtomicFS
force-pushed
the
test/coreboot-version-passing
branch
2 times, most recently
from
a1b68ed to
c1a1e20
Compare
MDr164
reviewed
Jan 21, 2025
AtomicFS
force-pushed
the
test/coreboot-version-passing
branch
from
c1a1e20 to
e1b4eb4
Compare
|
I have amended away the |
MDr164
reviewed
Jan 22, 2025
- just like we do "cache" for Linux or edk2 source code, we can also cache the coreboot repository to speed up the tests - now the coreboot tests takes 2 minutes instead of 10 on my laptop - the cache is not also in /tmp instead of working directory - gofumpt was crashing when the cached coreboot repo was in working directory Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
- expand existing coreboot tests to also test the embedded version string in the compiled coreboot binary Signed-off-by: AtomicFS <[email protected]>
- test how firmware-action handles passing of coreboot version into contianer Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
- make the git cloning functions use t.Helper() and pass in arguments in form of a struct Signed-off-by: AtomicFS <[email protected]>
AtomicFS
force-pushed
the
test/coreboot-version-passing
branch
from
e1b4eb4 to
e0ec491
Compare
MDr164
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for #495