Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): install newer NodeJS into edk2 containers #498

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

AtomicFS
Copy link
Collaborator

@AtomicFS AtomicFS commented Jan 9, 2025

  • some edk2 containers have NodeJS v16 or older, which are end-of-life
  • so let's add NodeJS repository for NodeJS v20 LTS
  • we could also do v18 LTS, but it is going to be end-of-life soon
  • only edk2 is finicky, other containers should rather upgrade the use Ubuntu version if this problem arises

fixes #494

@AtomicFS AtomicFS requested a review from MDr164 as a code owner January 9, 2025 12:45
@github-actions github-actions bot added docker docker related bugfix Bugfix / fix module/edk2 labels Jan 9, 2025
@AtomicFS AtomicFS enabled auto-merge January 9, 2025 12:45
- some edk2 containers have NodeJS v16 or older, which are end-of-life
- so let's add NodeJS repository for NodeJS v20 LTS
- we could also do v18 LTS, but it is going to be end-of-life soon
- only edk2 is finicky, other containers should rather upgrade the use
  Ubuntu version if this problem arises

Signed-off-by: AtomicFS <[email protected]>
@AtomicFS AtomicFS force-pushed the fix/new-nodejs-for-edk2 branch from 0b41a03 to 8777f69 Compare January 9, 2025 12:51
@AtomicFS AtomicFS added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 52d5cd8 Jan 9, 2025
102 of 103 checks passed
@AtomicFS AtomicFS deleted the fix/new-nodejs-for-edk2 branch January 9, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bugfix / fix docker docker related module/edk2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obsolete NodeJS in docker contrainers
2 participants