test(examples): expand to also run on arm64 machine #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
AtomicFS
force-pushed
the
test/expand-examples
branch
from
803cc18 to
3d0e114
Compare
AtomicFS
force-pushed
the
test/expand-examples
branch
4 times, most recently
from
6268dd8 to
65928ae
Compare
|
The failing job is dagger build for |
AtomicFS
force-pushed
the
test/expand-examples
branch
from
65928ae to
26e8194
Compare
Signed-off-by: AtomicFS <[email protected]>
- we are using 'amd64' and 'i386' everywhere else - so let's unify it and replace 'x86_64' and 'x86' Signed-off-by: AtomicFS <[email protected]>
- this way the examples can also run on arm64 machines Signed-off-by: AtomicFS <[email protected]>
- the code to detect if cross-compilation is needed did not work on arm64 - additionally, since everyone is naming architectures differently, I made 2 new functions to normalize (translate) into some common naming scheme Signed-off-by: AtomicFS <[email protected]>
- the mkdir might not be necessary, but should not do any harm - at one point I did run into this problem, but it might have been just because the arch variable was messed up Signed-off-by: AtomicFS <[email protected]>
- on self-hosted runners, the jobs leave behind all of their garbage which must be cleaned manually, otherwise the next job running on said self-hosted runner will fail (or contaminated) Signed-off-by: AtomicFS <[email protected]>
AtomicFS
force-pushed
the
test/expand-examples
branch
from
26e8194 to
12448b1
Compare
|
There was some left-over garbage in |
MDr164
reviewed
Nov 12, 2024
MDr164
previously approved these changes
Nov 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: AtomicFS <[email protected]>
|
Ups, the artifacts had conflicting names. Fixed. |
MDr164
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corebootonarm64urootonarm64linuxonarm64stitchingonarm64edk2 will come in later PR