Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #12, combined with a pregenerated build of the object files as required for a Git dependency of ring to work during Windows builds.
There are quite a few diffs in the object files this time (see more information on this here in the README) but after some analysis I believe they are expected and inert.
The tools I used for the analysis were:
delta
(better git diff viewer)AFAICT the changes were primarily caused by the increase in length of the exported symbol names (since we made the version number very large intentionally) instead of just increasing a single digit place. Here are examples of that and the other changes:
Here the drive letter and timestamp changed:
Here you can see length offsets and string lengths increasing:
And then here's the comparison between the old and new object file via the Ghidra-powered binary diffing of
ghidriff
, which indicates that nothing about the functions changed: